Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: PYTEST_ADDOPTS=-vv #4851

Merged
merged 2 commits into from Mar 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 9 additions & 4 deletions .travis.yml
Expand Up @@ -6,8 +6,13 @@ stages:
if: repo = pytest-dev/pytest AND tag IS NOT present
- name: deploy
if: repo = pytest-dev/pytest AND tag IS present
python:
- '3.7'
python: '3.7'
cache: false

env:
global:
- PYTEST_ADDOPTS=-vv

install:
- python -m pip install --upgrade --pre tox

Expand Down Expand Up @@ -57,7 +62,8 @@ jobs:
# - pytester's LsofFdLeakChecker
# - TestArgComplete (linux only)
# - numpy
- env: TOXENV=py37-lsof-numpy-xdist PYTEST_COVERAGE=1
# Empty PYTEST_ADDOPTS to run this non-verbose.
- env: TOXENV=py37-lsof-numpy-xdist PYTEST_COVERAGE=1 PYTEST_ADDOPTS=

# Specialized factors for py27.
- env: TOXENV=py27-nobyte-numpy-xdist
Expand Down Expand Up @@ -147,4 +153,3 @@ notifications:
skip_join: true
email:
- pytest-commit@python.org
cache: false
2 changes: 1 addition & 1 deletion azure-pipelines.yml
Expand Up @@ -3,7 +3,7 @@ trigger:
- features

variables:
PYTEST_ADDOPTS: "--junitxml=build/test-results/$(tox.env).xml"
PYTEST_ADDOPTS: "--junitxml=build/test-results/$(tox.env).xml -vv"
python.needs_vc: False
python.exe: "python"
COVERAGE_FILE: "$(Build.Repository.LocalPath)/.coverage"
Expand Down
69 changes: 52 additions & 17 deletions testing/test_assertrewrite.py
Expand Up @@ -127,7 +127,7 @@ def test_dont_rewrite_plugin(self, testdir):
result = testdir.runpytest_subprocess()
assert "warnings" not in "".join(result.outlines)

def test_name(self):
def test_name(self, request):
def f():
assert False

Expand All @@ -147,17 +147,41 @@ def f():
def f():
assert sys == 42

assert getmsg(f, {"sys": sys}) == "assert sys == 42"
verbose = request.config.getoption("verbose")
msg = getmsg(f, {"sys": sys})
if verbose > 0:
assert msg == (
"assert <module 'sys' (built-in)> == 42\n"
" -<module 'sys' (built-in)>\n"
" +42"
)
else:
assert msg == "assert sys == 42"

def f():
assert cls == 42 # noqa
assert cls == 42 # noqa: F821

class X(object):
pass

assert getmsg(f, {"cls": X}) == "assert cls == 42"

def test_dont_rewrite_if_hasattr_fails(self):
msg = getmsg(f, {"cls": X}).splitlines()
if verbose > 0:
if six.PY2:
assert msg == [
"assert <class 'test_assertrewrite.X'> == 42",
" -<class 'test_assertrewrite.X'>",
" +42",
]
else:
assert msg == [
"assert <class 'test_...e.<locals>.X'> == 42",
" -<class 'test_assertrewrite.TestAssertionRewrite.test_name.<locals>.X'>",
" +42",
]
else:
assert msg == ["assert cls == 42"]

def test_dont_rewrite_if_hasattr_fails(self, request):
class Y(object):
""" A class whos getattr fails, but not with `AttributeError` """

Expand All @@ -173,10 +197,16 @@ def __init__(self):
def f():
assert cls().foo == 2 # noqa

message = getmsg(f, {"cls": Y})
assert "assert 3 == 2" in message
assert "+ where 3 = Y.foo" in message
assert "+ where Y = cls()" in message
# XXX: looks like the "where" should also be there in verbose mode?!
message = getmsg(f, {"cls": Y}).splitlines()
if request.config.getoption("verbose") > 0:
assert message == ["assert 3 == 2", " -3", " +2"]
else:
assert message == [
"assert 3 == 2",
" + where 3 = Y.foo",
" + where Y = cls()",
]
blueyed marked this conversation as resolved.
Show resolved Hide resolved

def test_assert_already_has_message(self):
def f():
Expand Down Expand Up @@ -552,15 +582,16 @@ def f():

getmsg(f, must_pass=True)

def test_len(self):
def test_len(self, request):
def f():
values = list(range(10))
assert len(values) == 11

assert getmsg(f).startswith(
"""assert 10 == 11
+ where 10 = len(["""
)
msg = getmsg(f)
if request.config.getoption("verbose") > 0:
assert msg == "assert 10 == 11\n -10\n +11"
else:
assert msg == "assert 10 == 11\n + where 10 = len([0, 1, 2, 3, 4, 5, ...])"

def test_custom_reprcompare(self, monkeypatch):
def my_reprcompare(op, left, right):
Expand Down Expand Up @@ -608,7 +639,7 @@ def f():

assert getmsg(f).startswith("assert '%test' == 'test'")

def test_custom_repr(self):
def test_custom_repr(self, request):
def f():
class Foo(object):
a = 1
Expand All @@ -619,7 +650,11 @@ def __repr__(self):
f = Foo()
assert 0 == f.a

assert r"where 1 = \n{ \n~ \n}.a" in util._format_lines([getmsg(f)])[0]
lines = util._format_lines([getmsg(f)])
if request.config.getoption("verbose") > 0:
assert lines == ["assert 0 == 1\n -0\n +1"]
else:
assert lines == ["assert 0 == 1\n + where 1 = \\n{ \\n~ \\n}.a"]

def test_custom_repr_non_ascii(self):
def f():
Expand Down