Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: use xdist for py?? envs, keeping py27/py37 #4787

Merged
merged 4 commits into from Feb 15, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Feb 13, 2019

No description provided.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 13, 2019

TestEarlyRewriteBailout.test_cwd_changed failed on py34-xdist: https://travis-ci.org/pytest-dev/pytest/jobs/492822748#L281 - maybe only flaky, have not restarted it yet.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 13, 2019

Also fails with tox -e py34-xdist -- -n1 -k test_cwd_changed locally.

blueyed added a commit to blueyed/py that referenced this pull request Feb 13, 2019
Python 3.4 might raise FileNotFoundError due to `os.getcwd()` failing on
a non-existing cwd.  This is fixed in Python 3.5.

Ref: pytest-dev/pytest#4787 (comment)
@blueyed
Copy link
Contributor Author

blueyed commented Feb 13, 2019

Created pytest-dev/py#207 for a fix in py.

It gets triggered with -n1 because then "" is in sys.path, but with -n0 it is not.

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #4787 into master will decrease coverage by 1.63%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4787      +/-   ##
==========================================
- Coverage   95.64%   94.01%   -1.64%     
==========================================
  Files         113      113              
  Lines       25054    25052       -2     
  Branches     2488     2486       -2     
==========================================
- Hits        23963    23552     -411     
- Misses        769     1131     +362     
- Partials      322      369      +47
Flag Coverage Δ
#docs 29.53% <25%> (+0.01%) ⬆️
#doctesting 29.53% <25%> (+0.01%) ⬆️
#linting 29.53% <25%> (+0.01%) ⬆️
#linux 94.01% <75%> (-1.47%) ⬇️
#nobyte ?
#numpy 41.19% <25%> (-51.81%) ⬇️
#pexpect 41.19% <25%> (-0.86%) ⬇️
#pluggymaster ?
#py27 41.19% <25%> (-52.48%) ⬇️
#py34 ?
#py35 ?
#py36 ?
#py37 91.73% <75%> (-2.05%) ⬇️
#trial 41.19% <25%> (-51.81%) ⬇️
#windows ?
#xdist 91.73% <75%> (-1.91%) ⬇️
Impacted Files Coverage Δ
src/_pytest/terminal.py 91.85% <100%> (+0.81%) ⬆️
testing/test_assertrewrite.py 81.14% <66.66%> (-2.34%) ⬇️
src/_pytest/_code/_py2traceback.py 40% <0%> (-51.12%) ⬇️
src/_pytest/recwarn.py 83.6% <0%> (-14.76%) ⬇️
testing/python/integration.py 80.85% <0%> (-10.64%) ⬇️
src/_pytest/warnings.py 79.01% <0%> (-9.88%) ⬇️
src/_pytest/_io/saferepr.py 69.76% <0%> (-9.31%) ⬇️
testing/test_pathlib.py 91.17% <0%> (-8.83%) ⬇️
testing/test_pastebin.py 91.93% <0%> (-8.07%) ⬇️
src/_pytest/pytester.py 79.74% <0%> (-7.71%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2106515...40eef6d. Read the comment docs.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 13, 2019

Seems like codecov missed the intermediate failure with #py34 as of now.
Maybe after AppVeyor finishes.

blueyed added a commit to blueyed/py that referenced this pull request Feb 14, 2019
Python 3.4 might raise FileNotFoundError due to `os.getcwd()` failing on
a non-existing cwd.  This is fixed in Python 3.5.

Ref: pytest-dev/pytest#4787 (comment)
@blueyed
Copy link
Contributor Author

blueyed commented Feb 15, 2019

Would be good to get the fix for write_fspath_result into master / a bugfix release, since it causes also problems with py's tests for the fix there..

I'm going to rebased this against master.

@blueyed blueyed changed the base branch from features to master February 15, 2019 16:47
@blueyed
Copy link
Contributor Author

blueyed commented Feb 15, 2019

Cherry-picked xdist factor related commits from features.

@blueyed blueyed merged commit 498b994 into pytest-dev:master Feb 15, 2019
@blueyed blueyed deleted the travis-xdist branch February 15, 2019 17:35
blueyed added a commit to blueyed/py that referenced this pull request Feb 22, 2019
Python 3.4 might raise FileNotFoundError due to `os.getcwd()` failing on
a non-existing cwd.  This is fixed in Python 3.5.

Ref: pytest-dev/pytest#4787 (comment)
blueyed added a commit to blueyed/py that referenced this pull request Feb 22, 2019
Python 3.4 might raise FileNotFoundError due to `os.getcwd()` failing on
a non-existing cwd.  This is fixed in Python 3.5.

Ref: pytest-dev/pytest#4787 (comment)
blueyed added a commit to blueyed/py that referenced this pull request Mar 1, 2019
Python 3.4 might raise FileNotFoundError due to `os.getcwd()` failing on
a non-existing cwd.  This is fixed in Python 3.5.

Ref: pytest-dev/pytest#4787 (comment)
blueyed added a commit to blueyed/py that referenced this pull request Apr 5, 2019
Python 3.4 might raise FileNotFoundError due to `os.getcwd()` failing on
a non-existing cwd.  This is fixed in Python 3.5.

Ref: pytest-dev/pytest#4787 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants