Remove MarkInfo #4564
Merged
Remove MarkInfo #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
requested changes
Dec 19, 2018
There was a problem hiding this comment.
Thanks @RonnyPfannschmidt, this looked painful! 👍
Please update deprecations.rst and add a CHANGELOG entry following the format used by the other removal entries.
Codecov Report
@@ Coverage Diff @@
## features #4564 +/- ##
============================================
+ Coverage 95.71% 95.73% +0.02%
============================================
Files 111 111
Lines 24863 24663 -200
Branches 2449 2442 -7
============================================
- Hits 23797 23612 -185
+ Misses 751 740 -11
+ Partials 315 311 -4
Continue to review full report at Codecov.
|
nicoddemus
requested changes
Dec 20, 2018
|
Rebasing/merging on the latest |
RonnyPfannschmidt
force-pushed
the
remove-markinfo
branch
from
13186ac
to
d0afc85
Compare
nicoddemus
reviewed
Dec 20, 2018
|
now comes the task of actually collecting all the different issues with the removals and correctly reffering them ^^ |
You mean for the CHANGELOG? hehehe yeah, after that this is good to merge. 👍 |
nicoddemus
reviewed
Dec 20, 2018
RonnyPfannschmidt
force-pushed
the
remove-markinfo
branch
from
9743190
to
7da2d4a
Compare
nicoddemus
approved these changes
Dec 21, 2018
keywords are still a big issue
RonnyPfannschmidt
force-pushed
the
remove-markinfo
branch
from
9b1c22e
to
134641f
Compare
|
Hehehe I was just solving the conflicts myself. 😁 |
|
i found that kdiff3 is epic-ally better than github at resolving them (my rebase needed no work at all) |
|
💥 |
|
We are ready to release |
kaiwalyajoshi
added a commit
to mesosphere/dcos-commons
that referenced
this pull request
Jan 16, 2019
…d upstream as mentioned here: pytest-dev/pytest#4606 (comment) Quoted here incase that link breaks in the future: "We have removed item.get_marker, users should use item.get_closest_marker now (it's a long history, this was not an arbitrary change). Indeed I suspect pytest-cov might need to be updated." item.get_marker was removed in this PR pytest-dev/pytest#4564
kaiwalyajoshi
added a commit
to mesosphere/dcos-commons
that referenced
this pull request
Feb 21, 2019
…d upstream as mentioned here: pytest-dev/pytest#4606 (comment) Quoted here incase that link breaks in the future: "We have removed item.get_marker, users should use item.get_closest_marker now (it's a long history, this was not an arbitrary change). Indeed I suspect pytest-cov might need to be updated." item.get_marker was removed in this PR pytest-dev/pytest#4564
kaiwalyajoshi
added a commit
to mesosphere/dcos-commons
that referenced
this pull request
Feb 22, 2019
* Replace item.get_marker with item.get_closest_marker as it was removed upstream as mentioned here: pytest-dev/pytest#4606 (comment) Quoted here incase that link breaks in the future: "We have removed item.get_marker, users should use item.get_closest_marker now (it's a long history, this was not an arbitrary change). Indeed I suspect pytest-cov might need to be updated." item.get_marker was removed in this PR pytest-dev/pytest#4564 * Determine security mode of the cluster by querying the cluster instead of a local environment-variable. * Remove underscores from services names, this breaks for scenarios such as 'nonessential_tasks' where underscores are not allowed in task names. * Update frameworks/helloworld/tests/scale/test_scale.py Co-Authored-By: kaiwalyajoshi <kjoshi@mesosphere.com> * Address comments from code-review * Add support for soack configuration and custom service names, this can be used to differentiate the various hello-worlds. ie --service-name='orchestration/hello-world'
hroncok
added a commit
to hroncok/pip
that referenced
this pull request
Apr 4, 2019
xavfernandez
pushed a commit
to pypa/pip
that referenced
this pull request
Apr 4, 2019
gtristan
pushed a commit
to buildstream-migration/buildstream
that referenced
this pull request
Oct 9, 2020
Starting from `pytest` version 4.1.0, `Node.get_marker()` has been removed, and hence our tests break when running with newer versions of `pytest`. It was deprecated since a while back but it has recently been removed completely. Use `get_closest_marker()` as a replacement that is suggested in the changelog, and seems to work fine for our use case. See pytest-dev/pytest#4564 for more context on the upstream issue. One way of verifying this change is that this should fix the recently added `tests-fedora-update-deps` job, that was failing before due to this issue. (cherry picked from commit c91784a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes marker info in various ways
a) no more legacy marker objects on functions (this has surprising effects)
b) keywords are changes in a backward incompatible way as markerinfo goes away
c) plugin hook parsing needs an additional compatibility hack, i registered #4562
d) mark finding got a bit tighter to sort out mistakes in prior normalization
e) gruesome bugs in parameterize and fixture handling have been resolved by switching from attributes to definition markers
fixes #3515
fixes #3537 (removes legacy marker transfer which triggers the error)
fixes #891
fixes #4546