Change --strict help message to clarify it deals with unregistered markers #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
commented
Jul 4, 2017
| @@ -576,7 +576,7 @@ def test_strict_and_skip(self, testdir): | |||
| def test_hello(): | |||
| pass | |||
| """) | |||
| result = testdir.runpytest("-rs --strict") | |||
There was a problem hiding this comment.
Removed --strict from this test just because --strict doesn't really have anything to do with it.
There was a problem hiding this comment.
I just stumbled upon this test while working on #8384. It seems to me that with this change, the test (test_strict_and_skip) doesn't test what it intended to test, and it seems equal to test_skip_no_reason now.
Looking at 1fbd19b, the intention of the test was to check whether the skip marker is correctly registered by pytest, so I think this should be readded as --strict-markers, no?
There was a problem hiding this comment.
Good catch, thanks!
If you are working on #8384, would you mind doing that in the same PR?
RonnyPfannschmidt
approved these changes
Jul 5, 2017
The-Compiler
added a commit
to The-Compiler/pytest
that referenced
this pull request
Mar 3, 2021
The `--strict` argument was removed in pytest-dev#2552, but the removal wasn't actually correct - see pytest-dev#1472.
Merged
The-Compiler
added a commit
that referenced
this pull request
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2444
cc @okken