Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #12274

Merged
merged 4 commits into from Apr 30, 2024

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Apr 29, 2024

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.1 → v0.4.2](astral-sh/ruff-pre-commit@v0.4.1...v0.4.2)
- [github.com/pre-commit/mirrors-mypy: v1.9.0 → v1.10.0](pre-commit/mirrors-mypy@v1.9.0...v1.10.0)
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit is failing due to this ruff rule:

UP031 Use format specifiers instead of percent format

We need to decide if we want to fix them or ignore the new rule.

@Pierre-Sassoulas
Copy link
Contributor

That's a lot of changes, some looks funny, but overall I think it's better (and faster most of the time, I guess).

@Pierre-Sassoulas Pierre-Sassoulas added the dependencies Pull requests that update a dependency file label Apr 30, 2024
@Pierre-Sassoulas Pierre-Sassoulas dismissed their stale review April 30, 2024 16:15

Did not see that a lot of fixes had to be done, then did it.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Pierre-Sassoulas Pierre-Sassoulas merged commit 1385ec1 into main Apr 30, 2024
24 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the pre-commit-ci-update-config branch April 30, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants