[pylint] Fixes all use-maxplit-args, consider-using-enumerate, implicit-str-concat

[Pierre-Sassoulas]

Using maxsplit=1 from use-maxplit-args will make splits slightly faster and is the important one that will improve performances.

The other fix are about readability / style.

[Pierre-Sassoulas]

Converting to draft as I need to add tests for the missing coverage

[nicoddemus]

We can remove this:

Suggested change

	["*dir", "*dir", pytest.mark.skip("sys.version_info < (3,6)")(b"*dir")],
	["*dir", "*dir", b"*dir"],

[Pierre-Sassoulas]

Right ! Removed the reminder for the whole codebase in 7ded8d8

[RonnyPfannschmidt]

yikes, we had skip instead of skipif and the tests where broken

[Pierre-Sassoulas]

Thank you for looking into it, I was stuck. I'm not sure I understand though, should I replace ["*dir", "*dir", b"*dir"], back to ["*dir", "*dir", pytest.mark.skipif("sys.version_info < (3,6)")(b"*dir")], and then fix the tests ? Maybe in another merge request at this point ?

[RonnyPfannschmidt]

in the Visitor class of the local path clone, there is a condition we need to replace
https://github.com/pytest-dev/pytest/blob/main/src/_pytest/_py/path.py#L140 - it should also check for bytes

[RonnyPfannschmidt]

when asottile took out a lot of cruft a basestring usage was misinterpreted and replaced with just str

unfortunately the skips where wrong and thus the error was never noted as the tests skipped instead of passing