terminal: include markers in --collect-only
output
#11812
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1509
Note that I haven't done these yet:
As I have a few questions about how this should work and intend this PR to be a jumping off point for a conversation (as per @RonnyPfannschmidt 's suggestion in #1509).
My questions are:
--verbosity=-1
. On one hand this feels reasonable as that outputs one test per line and for grepping purposes that makes most sense. However it feels then a bit weird that it's not included in more verbose levels ofcollect-only
. Though having the marks in an output format where each test is multiple lines makes is kinda annoying from the POV of grepping... Maybe a new flag could be added (e.g.--collect-only-include-markers
)? This seems a little clunky TBH though. Ultimately if we want to consume the output of--collect-only
programmatically then I think some formal structured data output makes most sense (e.g. json) but that's quite a bit more work than what I did here.