Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR resolves #11457.
Description:
Essentially, the issue is that when the user calls .fail() and the test case has an internal error, they will receive the reason for failing passed to .fail() as well as the internal error context. The figure below was the test given to produce this behaviour:
And the following figure is the behaviour itself:
Solution:
This was described as unfavourable, so to prevent this behaviour, I added a suppress context parameter to the .fail() function to allow users to choose whether they want to internal error context to be printed. Now, with running the same test, we choose to suppress the context:
This gives us the following result:
I believe this is an apt fix as suppress_context is set to False by default, meaning that it would not change the default behaviour, but gives the user more overall control of their text outputs.
Information
Head-fork: seanpourgoutzidis/pytest
compare: issue11457
base-fork: pytest-dev/pytest
base: main
Thanks,
Sean