Correct the spelling of ArgSource.INVOCATION_DIR

[jparise]

This was spelled incorrectly when introduced in #9897.

[jparise]

If there are backwards-compatibility concerns, we could also add an alias:

INCOVATION_DIR = INVOCATION_DIR

[bluetech]

Yes, we should add an alias, otherwise it'd be a breaking change.

[bluetech]

Thanks (also for adding the tests)!

I'll add a note to the changelog that an alias remains.

[The-Compiler]

Wouldn't it make sense to use a __getattr__ or somesuch for the alias, so that it can show a deprecation warning and we can remove it in the future?

[bluetech]

Deprecations == pain, IMO it's not worth it for something like an alias.

[jparise]

Wouldn't it make sense to use a __getattr__ or somesuch for the alias, so that it can show a deprecation warning and we can remove it in the future?

I don't have a strong preference either way, but I'd be happy to implement this approach if it's more aligned with the project's norms.

As an aside, the old (misspelled) symbol doesn't appear to have been used by any open source (on GitHub) code: https://github.com/search?q=INCOVATION_DIR+lang%3Apython&type=code

... but that is of course an incomplete view.