Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reference to non-existent module #10978

Merged
merged 1 commit into from May 10, 2023
Merged

fix reference to non-existent module #10978

merged 1 commit into from May 10, 2023

Conversation

bzoracler
Copy link
Contributor

This is a minor fix to a reference to a no-longer-existing private module. There should be no runtime effects, because the fix is made under a typing.TYPE_CHECKING block.


I've read through #7469, where there was a public API typing change

  • _pytest.code.ExceptionInfo -> pytest.ExceptionInfo

but as the rest of the references in the same block in _pytest/hookspec.py are all for private modules, I thought it would be best to continue using a private module instead of switching the reference to a public from pytest import ExceptionInfo.

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bluetech bluetech merged commit 5b75b0d into pytest-dev:main May 10, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants