Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fixtures named teardown being considered by nose #10696

Merged
merged 3 commits into from Jan 27, 2023
Merged

Fix fixtures named teardown being considered by nose #10696

merged 3 commits into from Jan 27, 2023

Conversation

Tbruno25
Copy link
Contributor

Closes #10597
This behavior seems to have been introduced in #9273

Since I noticed support for nose is being deprecated I didn't add any additional test coverage.
But I'm not familiar with how pytest should interact with nose so any additional verification is welcome :)

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Could you also add a regression test in test_nose.py, to ensure this is working (and keeps working in the future)? Thanks!

changelog/10597.bugfix.rst Outdated Show resolved Hide resolved
Tbruno25 and others added 2 commits January 27, 2023 08:01
Add a more descriptive changelog entry.

Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, appreciate it!

@nicoddemus nicoddemus merged commit 5dbfb8e into pytest-dev:main Jan 27, 2023
@nicoddemus nicoddemus changed the title Bugfix nose teardown regression Fix fixtures named teardown being considered by nose Jan 27, 2023
@Tbruno25 Tbruno25 deleted the tj/bugfix/10597 branch January 27, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If a fixture is called teardown, tests fail
2 participants