Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.2.x] Derive pytest.raises from AbstractContextManager #10673

Merged
merged 1 commit into from Jan 19, 2023
Merged

[7.2.x] Derive pytest.raises from AbstractContextManager #10673

merged 1 commit into from Jan 19, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport of PR #10660 to 7.2.x branch. PR created by backport workflow.

@RonnyPfannschmidt
Copy link
Member

@nicoddemus the original author goes mia, that needs to be fixed

@nicoddemus nicoddemus closed this Jan 19, 2023
@nicoddemus nicoddemus reopened this Jan 19, 2023
@nicoddemus
Copy link
Member

nicoddemus commented Jan 19, 2023 •
edited

@nicoddemus the original author goes mia, that needs to be fixed

What do you mean, what needs to be fixed?

@RonnyPfannschmidt
Copy link
Member

@nicoddemus the commit should be attributed to the initial contributors, not the merger

@nicoddemus
Copy link
Member

Sorry, not clear yet to me:

  1. Is this a problem with the backport workflow?
  2. Did you do this manually and would like to change the commit author?

I'm confused as to why was I pinged... do I need to do something?

@RonnyPfannschmidt
Copy link
Member

This was the backport workflows

I vaguely recalled that you worked on it

@nicoddemus
Copy link
Member

OK, created #10676.

I will not tackle that soon, do you think this is a blocker? Note that all backports done so far have this issue.

@RonnyPfannschmidt
Copy link
Member

Let's not consider this a blocker then

@nicoddemus nicoddemus merged commit 9c103ae into 7.2.x Jan 19, 2023
@nicoddemus nicoddemus deleted the backport-10660-to-7.2.x branch January 19, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RonnyPfannschmidt @nicoddemus