Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if config args and args_source exist #10664

Merged
merged 4 commits into from Jan 21, 2023
Merged

Check if config args and args_source exist #10664

merged 4 commits into from Jan 21, 2023

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Jan 14, 2023

Closes #10626

nicoddemus
nicoddemus requested changes Jan 19, 2023
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think however a better solution would be to initialize args and args_source during Config.__init__, as [] and ArgsSource.ARGS respectively.

@q0w
Copy link
Contributor Author

q0w commented Jan 19, 2023

Will do

@q0w @nicoddemus
Update changelog/10626.bugfix.rst
00c8bea 
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
@q0w

This comment was marked as outdated.

Sign in to view
@nicoddemus nicoddemus merged commit bd7919e into pytest-dev:main Jan 21, 2023
@nicoddemus
Copy link
Member

Thanks @q0w!

@github-actions github-actions bot mentioned this pull request Jan 21, 2023
Merged
@q0w q0w deleted the fixtures-help branch January 22, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception on pytest --fixture --help
3 participants
@q0w @nicoddemus @pytestbot