New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for zero denominator in approx #10624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jayendra-patil33!
Could you please:
-
Add a test to avoid future regressions?
-
Add a changelog entry, as a new file
changelog/10533.bugfix.rst
describing the fix, like:Fix :func:`pytest.approx` handling of dictionaries containing one or more values of `0.0`.
Done |
I don't see the requested changes, did you forget to push perhaps? |
Sorry, it seems that was indeed the case, now I have pushed the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
closes #10533