Fix option error #10608
Merged
Fix option error #10608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d044e9f.
nicoddemus
requested changes
Jan 4, 2023
There was a problem hiding this comment.
Hi @markshao,
Thanks for the PR!
Can you include a simple integration test to ensure this does not regress in the future? Thanks!
nicoddemus
reviewed
Jan 4, 2023
update rst message Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Added , pls take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #10592
if the cmdline contains both the
--cache-showand--helpoption will cause the internal error . But if contains the--collect-onlyand--helpwill just output the help message.the root cause is inside
pytest_cmdline_mainofcacheprovider, it will really execute thewrap_session, but it will raise exception due to missing variable assignment . so add the condition express to avoid the conflict .