Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore editable installation modules #10231

Merged
merged 5 commits into from Aug 26, 2022
Merged

Ignore editable installation modules #10231

merged 5 commits into from Aug 26, 2022

Conversation

GergelyKalmar
Copy link
Contributor

@GergelyKalmar GergelyKalmar commented Aug 20, 2022

Fixes #10230, relatively trivial change.

  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.
  • Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.

If this change fixes an issue, please:

  • Add text like closes #XYZW to the PR description and/or commits (where XYZW is the issue number). See the github docs for more information.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.

  • Add yourself to AUTHORS in alphabetical order.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you add a unittest for this please? There is a test in test_config.py that I think you can update.

@RonnyPfannschmidt RonnyPfannschmidt linked an issue Aug 22, 2022 that may be closed by this pull request
@GergelyKalmar
Copy link
Contributor Author

Tests are added now. Could we release it soon, if necessary as a separate patch? There will be more and more people hitting this as they're upgrading pip to newer versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning due to PEP660 editable packages PytestAssertRewriteWarning when installing a plugin in editable mode
2 participants