Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix partially unknown type #10204

Merged
merged 1 commit into from Aug 12, 2022
Merged

Fix partially unknown type #10204

merged 1 commit into from Aug 12, 2022

Conversation

brandonchinn178
Copy link
Contributor

Related to #7469

The-Compiler
The-Compiler approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@The-Compiler The-Compiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicit is better than implicit, I guess - thanks!

@The-Compiler The-Compiler merged commit 4d430ea into pytest-dev:main Aug 12, 2022
@brandonchinn178 brandonchinn178 deleted the pyright branch August 12, 2022 15:16
@brandonchinn178
Copy link
Contributor Author

ah sorry I guess I didnt note the motivation: this fixes pyright in strict mode, which errored with "Partially unknown type"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-Compiler The-Compiler The-Compiler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandonchinn178 @The-Compiler