Explicit note that tmpdir fixture is discouraged in favour of tmp_path #9937 #10138
Conversation
on-behalf-of: @clarityai-eng <tech@clarity.ai> Add changelog entry on-behalf-of: @clarityai-eng <tech@clarity.ai> Added mob programming authors on-behalf-of: @clarityai-eng <tech@clarity.ai>
There was a problem hiding this comment.
Thanks @Wolfremium13, appreciate it!
Please take a look at my comments.
| @@ -87,6 +87,7 @@ Damian Skrzypczak | |||
| Daniel Grana | |||
| Daniel Hahler | |||
| Daniel Nuri | |||
| Daniel Sánchez Castelló | |||
There was a problem hiding this comment.
Why are you adding this many people? Usually PR authors just add themselves. Not sure it is OK to add other people without their consent.
There was a problem hiding this comment.
Hi @nicoddemus, this PR is part of a mob-programming session at @clarityai-eng.
The people involved in the thinking and writing of this change are:
@toclarity - Tatiana
@Wolfremium13 - Kevin
@victorrmclarity - Victor
@DaniSancas - Daniel
Is it correct to write all our names in the AUTHORS section or should we delete some of them?
There was a problem hiding this comment.
Ahh no worries then, thanks for the clarification. I assume everyone consents to this so it is fine. 👍
There was a problem hiding this comment.
Yes, everyone on the list was in the session and gave their consent.
It's the first time we contribute to this project. Are there any next steps to be done?
Thank you!
There was a problem hiding this comment.
No that's it!
Thanks @toclarity, @Wolfremium13, @victorrmclarity, and @DaniSancas for the contribution! 👍
on-behalf-of: @clarityai-eng <tech@clarity.ai> Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
nicoddemus
changed the title
Explicit note that
tmpdirfixture is discouraged in favour oftmp_path.Closes #9937
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.AUTHORSin alphabetical order.