New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PurePath directly instead of os.path.sep in rewrite.py #10078
Conversation
The ubuntu-pypy3 is unrelated and can be ignored for now. |
FWIW this is official API: https://docs.python.org/3/library/os.html#os.sep
I wonder, since we are changing this anyways, wouldn't something like |
Oh TIL. Then I'm not sure what the problem in #9791 is. 🤔 We could use EDIT: I remembered now that the source of |
We do already use |
Given we are already creating a `PurePath`, just pass the parts directly to it. This avoids using `os.path.sep`, that although is an official API, seems not to be available in all systems. Fix pytest-dev#9791
You folks are right, updated, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given we are already creating a
PurePath
, just pass the parts directly to it.This avoids using
os.path.sep
, that although is an official API, seems not to be available in all systems.Fix #9791