Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update :class:pytest.PytestUnhandledCoroutineWarning to a deprecation; it will raise an error in pytest 8. [SQUASH] #10012

Merged
merged 5 commits into from Aug 8, 2022
Merged

Update :class:pytest.PytestUnhandledCoroutineWarning to a deprecation; it will raise an error in pytest 8. [SQUASH] #10012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a7be13b
deprecate returning awaitables
graingert Jul 29, 2022
0d55dee
Create 10012.deprecation.rst
graingert Aug 3, 2022
e5a4b70
Update 10012.deprecation.rst
graingert Aug 3, 2022
7a4cf2a
Update 10012.deprecation.rst
graingert Aug 3, 2022
42950ad
Update changelog/10012.deprecation.rst
graingert Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/10012.deprecation.rst
View file
Open in desktop
@@ -0,0 +1 @@
Update :class:`pytest.PytestUnhandledCoroutineWarning` to a deprecation; it will raise an error in pytest 8.
3 changes: 1 addition & 2 deletions src/_pytest/warning_types.py
View file
Open in desktop
Expand Up @@ -55,7 +55,6 @@ class PytestRemovedIn8Warning(PytestDeprecationWarning):
__module__ = "pytest"


@final
class PytestReturnNotNoneWarning(PytestDeprecationWarning):
Copy link
Member Author

@graingert graingert Jul 29, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RonnyPfannschmidt requested that PytestReturnNotNoneWarning be a RemovedIn8Warning and I agree, but the @final decorator on RemovedIn8Warning prevents that.

"""Warning emitted when a test function is returning value other than None."""

Expand All @@ -82,7 +81,7 @@ def simple(cls, apiname: str) -> "PytestExperimentalApiWarning":


@final
class PytestUnhandledCoroutineWarning(PytestWarning):
class PytestUnhandledCoroutineWarning(PytestReturnNotNoneWarning):
"""Warning emitted for an unhandled coroutine.

A coroutine was encountered when collecting test functions, but was not
Expand Down