Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for python3.9 #7179

Merged
merged 1 commit into from May 7, 2020
Merged

Fix tests for python3.9 #7179

merged 1 commit into from May 7, 2020

Conversation

asottile
Copy link
Member

@asottile asottile commented May 7, 2020

Resolves #7161

  • the text of SyntaxErrors changed as part of the PEG parser rewrite (bpo-40334)
  • inspect.getsource improved in python3.9 (utilizing the ast and __qualname__) (bpo-35113)

@asottile asottile mentioned this pull request May 7, 2020
Merged
@hroncok hroncok self-requested a review May 7, 2020 12:56
hroncok
hroncok approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@hroncok hroncok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acking the code changes. Whether or not pytest wants to have a nightly build of 3.9 in the CI is not for me to say.

testing/code/test_source.py Show resolved Hide resolved
@hroncok
Copy link
Member

hroncok commented May 7, 2020

A backport: #7181

@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label May 7, 2020
nicoddemus
nicoddemus approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asottile!

@nicoddemus
Copy link
Member

@asottile after this gets merged, could you please backport this to 5.4.x?

@nicoddemus nicoddemus mentioned this pull request May 7, 2020
Closed
@nicoddemus nicoddemus merged commit 63e94b9 into pytest-dev:master May 7, 2020
@asottile
Copy link
Member Author

asottile commented May 7, 2020

yep will do!

@asottile asottile deleted the py39 branch May 7, 2020 20:44
@asottile asottile added backported PR has been backported to the current bug-fix branch and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels May 7, 2020
hroncok pushed a commit to hroncok/pytest that referenced this pull request May 7, 2020
@nicoddemus @hroncok
[4.6] Merge pull request pytest-dev#7179 from asottile/py39
2a5ca51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

@hroncok hroncok hroncok approved these changes

Assignees
No one assigned
Labels
backported PR has been backported to the current bug-fix branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New test failures with Python 3.9.0a6
3 participants
@asottile @hroncok @nicoddemus