minor: visit_Assert: move setting of negation out of branches

pytest-dev · Nov 18, 2019 · f38f2d4 · f38f2d4
1 parent 64d8910
commit f38f2d4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/_pytest/assertion/rewrite.py b/src/_pytest/assertion/rewrite.py
@@ -807,8 +807,9 @@ def visit_Assert(self, assert_):
                 )
             )
 
+        negation = ast.UnaryOp(ast.Not(), top_condition)
+
         if self.enable_assertion_pass_hook:  # Experimental pytest_assertion_pass hook
-            negation = ast.UnaryOp(ast.Not(), top_condition)
             msg = self.pop_format_context(ast.Str(explanation))
 
             # Failed
@@ -860,7 +861,6 @@ def visit_Assert(self, assert_):
         else:  # Original assertion rewriting
             # Create failure message.
             body = self.expl_stmts
-            negation = ast.UnaryOp(ast.Not(), top_condition)
             self.statements.append(ast.If(negation, body, []))
             if assert_.msg:
                 assertmsg = self.helper("_format_assertmsg", assert_.msg)