Merge pull request #8419 from pytest-dev/all-repos_autofix_all-repos-…

…manual clean up mkdtemp usage
pytest-dev · Mar 9, 2021 · 38d8deb · 38d8deb
2 parents 79b03ce + 7a6ec56
commit 38d8deb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/doc/en/fixture.rst b/doc/en/fixture.rst
@@ -2228,20 +2228,18 @@ file:
     # content of conftest.py
 
     import os
-    import shutil
     import tempfile
 
     import pytest
 
 
     @pytest.fixture
     def cleandir():
-        old_cwd = os.getcwd()
-        newpath = tempfile.mkdtemp()
-        os.chdir(newpath)
-        yield
-        os.chdir(old_cwd)
-        shutil.rmtree(newpath)
+        with tempfile.TemporaryDirectory() as newpath:
+            old_cwd = os.getcwd()
+            os.chdir(newpath)
+            yield
+            os.chdir(old_cwd)
 
 and declare its use in a test module via a ``usefixtures`` marker:
 

diff --git a/testing/test_assertrewrite.py b/testing/test_assertrewrite.py
@@ -1395,12 +1395,10 @@ def test_cwd_changed(self, pytester: Pytester, monkeypatch) -> None:
             **{
                 "test_setup_nonexisting_cwd.py": """\
                     import os
-                    import shutil
                     import tempfile
 
-                    d = tempfile.mkdtemp()
-                    os.chdir(d)
-                    shutil.rmtree(d)
+                    with tempfile.TemporaryDirectory() as d:
+                        os.chdir(d)
                 """,
                 "test_test.py": """\
                     def test():