Ignore Python 3.8 specific failure in pytest for now #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenstaro
force-pushed
the
ignore-python38-failure
branch
from
5f56eaf
to
e1ec3fa
Compare
svenstaro
force-pushed
the
ignore-python38-failure
branch
from
e1ec3fa
to
8714a99
Compare
RonnyPfannschmidt
approved these changes
May 1, 2020
|
thanks for the markings, we will have to followup once the fixup is actually released in pytest |
blueyed
reviewed
Jul 10, 2020
| @@ -186,6 +189,7 @@ def test_crash(): | |||
| ) | |||
| assert result.ret == 1 | |||
|
|
|||
| @pytest.mark.xfail(reason="#527: Ignore Python 3.8 failure for the time being") | |||
There was a problem hiding this comment.
Just for reference: I do not think this is py38 specific, but rather pytest related only (pytest-dev/pytest#6981 (comment)).
(just leaving this here since I was confused why pytestmaster was not failing anymore)
Build log for the (now swallowed) failure: https://travis-ci.org/github/pytest-dev/pytest-xdist/jobs/669139507#L255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest we xmark these tests for the time being until pytest upstream issues are resolved.
The failure of
testdir.tmpdiron Python 2 is/tmp/pytest-of-svenstaro/pytest-326/test_basetemp_in_subprocesses0/runpytest-0/popen-gw0/test_send0while in Python 3 it is
/tmp/pytest-of-svenstaro/pytest-327/tmp-test_basetemp_in_subprocesses0/pytest-of-svenstaro/pytest-0/test_send0It's not an optimal fix but at least we'll be able to more easily notice actual test failure in
pytest-xdist-specific code again. Currently, everything just fails which isn't optimal.