Switch to Pytest's terminal reporter #162
Conversation
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch
force-pushed
the
master
branch
2 times, most recently
from
d0afc0e
to
ca86ac4
Compare
pytest_timeout.py
Outdated
| yield | ||
| finally: | ||
| if is_timeout and settings.func_only is False: | ||
| hooks.pytest_timeout_cancel_timer(item=item) |
There was a problem hiding this comment.
this seems like quite an important bugfix. could you update the changelog as well?
There was a problem hiding this comment.
With old style hook wrappers it's incorrect to add try/finally
There was a problem hiding this comment.
Oh?!
Does the code after the yield always run then?
Got a link to something I could read? I have several plugins which might need to be updated...
What's the consequence?
There was a problem hiding this comment.
For legacy hook wrappers one needs to check the exception attribute if one needs to handle them
Moder hookwrappers Work like expected
| def test_not_main_thread(testdir): | ||
| testdir.makepyfile( | ||
| def test_not_main_thread(pytester): | ||
| pytest.skip("The 'pytest_timeout.timeout_setup' function no longer exists") |
There was a problem hiding this comment.
i'm confused by this, why is there still a test for it then?
There was a problem hiding this comment.
This was broken in dd9d6080763c559de1ff5b15deb9c27559dd3431 and the test was broad enough that it kept passing.
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Done. |
I'd love that! |
Additionally update pre-commit hook versions