Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix is_debugging for pydevd with cython (#146) #155

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix is_debugging for pydevd with cython (#146) #155

merged 1 commit into from
Oct 19, 2023

Conversation

adigie
Copy link
Contributor

@adigie adigie commented Oct 17, 2023

When trace_func comes from cython module, inspect.getmodule returns None. Fallback to getting module from __class__ of trace_func.

Closes #146

@adigie
Fix is_debugging for pydevd with cython (#146)
f7f5046 
When `trace_func` comes from cython module, `inspect.getmodule`
returns `None`. Fallback to getting module from `__class__` of
`trace_func`.
flub
flub approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the good commit message as well!

@flub flub merged commit 2dd6fb6 into pytest-dev:master Oct 19, 2023
12 checks passed
@adigie adigie deleted the gh-146 branch October 19, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flub flub flub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is_debugging does not work in VS Code
2 participants
@adigie @flub