Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pyproject.toml and setup.cfg #151

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Conversation

swt2c
Copy link
Contributor

@swt2c swt2c commented Oct 5, 2023

This enables building/installing without using deprecated setup.py (but setup.py is still available).

This enables building/installing without using deprecated setup.py (but
setup.py is still available).
@flub
Copy link
Member

flub commented Oct 5, 2023

I know there have been lots of changes on the packaging side in python. But I haven't been keeping up. Is currently one of the recommended approaches? How do you build sdist and wheel without invoking setup.py? And finally, if setup.py is not needed, is there any point in keeping it around?

In general I like the look of this and would be happy to get rid of an executable setup.py.

@swt2c
Copy link
Contributor Author

swt2c commented Oct 5, 2023

Yes, this is one of the recommended approaches - although perhaps only if you're interested in keeping a setup.py around for now. That's what I did since it was consistent with pytest itself. It's also possible to get rid of setup.py, setup.cfg, and do everything in pyproject.toml.

To build sdist and wheel without using setup.py, the recommended approach is to use build. For example python -m build.

@flub
Copy link
Member

flub commented Oct 8, 2023

Sounds good, I'd probably be fine with getting rid of setup.py entirely but this is also fine.

@flub flub merged commit 263db99 into pytest-dev:master Oct 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants