Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Model Bakery seeding to default seeded packages #564

Merged
merged 8 commits into from Aug 15, 2023
Merged

Add Model Bakery seeding to default seeded packages #564

merged 8 commits into from Aug 15, 2023

Conversation

nefrob
Copy link
Contributor

@nefrob nefrob commented Aug 7, 2023 •
edited

Seeds baker by default

Re: #563.

Changes

  • Adds baker seeding and tests

Action items

  • bump dependency lockfiles

nefrob
nefrob commented Aug 7, 2023
View reviewed changes
README.rst Outdated Show resolved Hide resolved
adamchainz
adamchainz requested changes Aug 8, 2023
View reviewed changes
Copy link
Member

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting started on this!

Add a documentation note and changelog note. Copy the formats of the existing docs.

Remove the emoji from the PR title.

README.rst Outdated Show resolved Hide resolved
src/pytest_randomly/__init__.py Outdated Show resolved Hide resolved
src/pytest_randomly/__init__.py Outdated Show resolved Hide resolved
tests/test_pytest_randomly.py Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@nefrob nefrob changed the title ✨ Add baker seeding to default seeded packages Add baker seeding to default seeded packages Aug 8, 2023
@nefrob nefrob changed the title Add baker seeding to default seeded packages Add Model Bakery seeding to default seeded packages Aug 8, 2023
nefrob
nefrob commented Aug 8, 2023
View reviewed changes
requirements/requirements.in Outdated Show resolved Hide resolved
@nefrob nefrob marked this pull request as ready for review August 11, 2023 15:22
@nefrob nefrob requested a review from adamchainz August 11, 2023 15:22
adamchainz
adamchainz reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, looks good, just some minor improvements that I'll work on now before merging.

CHANGELOG.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
tests/test_pytest_randomly.py Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
adamchainz
adamchainz reviewed Aug 15, 2023
View reviewed changes
requirements/requirements.in Outdated Show resolved Hide resolved
src/pytest_randomly/__init__.py Outdated Show resolved Hide resolved
@adamchainz adamchainz merged commit 4e6d28b into pytest-dev:main Aug 15, 2023
6 checks passed
@adamchainz
Copy link
Member

Released in 3.14.0, enjoy!

@nefrob
Copy link
Contributor Author

nefrob commented Aug 15, 2023

@adamchainz thanks so much!

@nefrob nefrob mentioned this pull request Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamchainz adamchainz adamchainz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nefrob @adamchainz