Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct type annotations in patch.dict() #235

Merged
merged 2 commits into from Apr 24, 2021

Conversation

plannigan
Copy link

@plannigan plannigan commented Apr 19, 2021

The documentation for patch.dict() says:

in_dict can be a dictionary or a mapping like container. If it is a mapping then it must at least support getting, setting and deleting items plus iterating over keys.
in_dict can also be a string specifying the name of the dictionary, which will then be fetched by importing it.

However, the argument is currently annotation is Mapping[Any, Any]. This updates the annotation to also include the string option.

@plannigan
Copy link
Author

It looks like the CI failures are not related to my changes.

  • setuptools_scm recently released v6.0, which dropped support for python 3.5
  • The linting stage is setup to use python 3.7, but tox is trying to use python 3.6.

@nicoddemus
Copy link
Member

Thanks, looks good!

Could you also add a CHANGELOG entry?

@plannigan
Copy link
Author

Sure, updated now.

@nicoddemus nicoddemus merged commit 28ef007 into pytest-dev:master Apr 24, 2021
@nicoddemus
Copy link
Member

nicoddemus commented Apr 24, 2021

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants