Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Codecov #480

Merged
merged 2 commits into from Jan 17, 2022
Merged

Disable Codecov #480

merged 2 commits into from Jan 17, 2022

Conversation

BeyondEvil
Copy link
Contributor

@BeyondEvil BeyondEvil commented Jan 17, 2022

Disable Codecov until someone has time to upgrade to v2 and figure out why it fails (after upgrading).

Also disable pypy3, because: actions/setup-python#311

@BeyondEvil BeyondEvil requested a review from a team January 17, 2022 09:50
@BeyondEvil BeyondEvil changed the title Skip Codecov for scheduled runs Disable Codecov Jan 17, 2022
@BeyondEvil
Copy link
Contributor Author

Why are the pypy3 tests so slow!?

@RonnyPfannschmidt
Copy link
Member

most likely compounding effects,

for sanity, lets create 2 followup tickets (for codecov v2 and pypy3 fixes) + link them in comments

afterwards i believe its fine to merge

thanks for kicking this off

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per prev comment, lets add followup issues and link them in the code comments

@BeyondEvil
Copy link
Contributor Author

most likely compounding effects,

for sanity, lets create 2 followup tickets (for codecov v2 and pypy3 fixes) + link them in comments

afterwards i believe its fine to merge

thanks for kicking this off

Good idea!

Yeah, sorry for having been a ghost.

@BeyondEvil
Copy link
Contributor Author

All green @RonnyPfannschmidt :)

Once this is merged, I'm going to pickup a bunch of other issues/fixes.

@BeyondEvil BeyondEvil merged commit 3d139d3 into pytest-dev:master Jan 17, 2022
@BeyondEvil BeyondEvil deleted the fix-codecov-issue branch January 17, 2022 13:19
@RonnyPfannschmidt
Copy link
Member

@BeyondEvil don't worry about some absence, this is the volunteer work, so even without the pandemic piling on top its sometimes much

BeyondEvil added a commit that referenced this pull request Jan 26, 2022
* remove phantomjs dependency (#424)

* properly classify all npm dependencies (#425)

* Move the changelog to read the docs (#423)

* split plugin.py into smaller files (#427)

* Implement the visible URL query parameter to control visibility of test results on page load. (#433)

* enable control of test result visability via query params

* Allow for redacting of environment table values (#431)

* Disable Codecov (#480)

* Disable Codecov

* Disable pypy3 on mac

* Add Tests.yml reusable workflow (#484)

* Use the tests reusable workflow (#486)

* Migrate to precommit.ci (#487)

* Separate Nightly workflow (#488)

Co-authored-by: Gleb Nikonorov <gleb.i.nikonorov@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@ssbarnea ssbarnea added the skip-changelog Can be missed from the changelog. label Jul 4, 2022
BeyondEvil added a commit to BeyondEvil/pytest-html that referenced this pull request Apr 3, 2023
* remove phantomjs dependency (pytest-dev#424)

* properly classify all npm dependencies (pytest-dev#425)

* Move the changelog to read the docs (pytest-dev#423)

* split plugin.py into smaller files (pytest-dev#427)

* Implement the visible URL query parameter to control visibility of test results on page load. (pytest-dev#433)

* enable control of test result visability via query params

* Allow for redacting of environment table values (pytest-dev#431)

* Disable Codecov (pytest-dev#480)

* Disable Codecov

* Disable pypy3 on mac

* Add Tests.yml reusable workflow (pytest-dev#484)

* Use the tests reusable workflow (pytest-dev#486)

* Migrate to precommit.ci (pytest-dev#487)

* Separate Nightly workflow (pytest-dev#488)

Co-authored-by: Gleb Nikonorov <gleb.i.nikonorov@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Can be missed from the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants