Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add async client fixture #865

Merged
merged 5 commits into from Oct 18, 2020
Merged

add async client fixture #865

merged 5 commits into from Oct 18, 2020

Conversation

pbelskiy
Copy link
Contributor

No description provided.

@pbelskiy
Copy link
Contributor Author

Related to #864

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pbelskiy, this looks good.

It will be good to rebase on latest master, the CI is overhauled and should be green now.

We need to figure out the recommendation. But if nothing clears up, we can stick with pytest-asyncio setup. It is just an example so can be fixed later.

I think for completion we should also add an async_rf fixture which creates an AsyncRequestFactory.

docs/helpers.rst Outdated Show resolved Hide resolved
docs/helpers.rst Show resolved Hide resolved
@bluetech
Copy link
Member

@pbelskiy You requested my review but not sure if you've seen my other comments. CI fails as well.

@pbelskiy pbelskiy closed this Oct 17, 2020
@pbelskiy pbelskiy reopened this Oct 17, 2020
@pbelskiy
Copy link
Contributor Author

Rebased, tests is okay now

@bluetech

I think for completion we should also add an async_rf fixture which creates an AsyncRequestFactory

Do you suggest to add this to this PR or new one?

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you suggest to add this to this PR or new one?

If you don't mind, would be good to do it in this PR already.

docs/helpers.rst Show resolved Hide resolved
@pbelskiy
Copy link
Contributor Author

@bluetech Done. But I removed :class: prefix from docs for new fixtures:

An instance of a django.test.AsyncClient
An instance of a django.test.AsyncRequestFactory

Becase it leads to build documentation error, I don't understand why.

@bluetech bluetech merged commit 3e8ff2a into pytest-dev:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants