New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add async client fixture #865
Conversation
Related to #864 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pbelskiy, this looks good.
It will be good to rebase on latest master, the CI is overhauled and should be green now.
We need to figure out the recommendation. But if nothing clears up, we can stick with pytest-asyncio setup. It is just an example so can be fixed later.
I think for completion we should also add an async_rf
fixture which creates an AsyncRequestFactory
.
@pbelskiy You requested my review but not sure if you've seen my other comments. CI fails as well. |
Rebased, tests is okay now
Do you suggest to add this to this PR or new one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you suggest to add this to this PR or new one?
If you don't mind, would be good to do it in this PR already.
@bluetech Done. But I removed An instance of a Becase it leads to build documentation error, I don't understand why. |
No description provided.