Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Make django_settings_is_configured return the first value always #708

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[WIP] Make django_settings_is_configured return the first value always #708

wants to merge 5 commits into from

Commits on Aug 30, 2019

  1. Make django_settings_is_configured return the first value always 

    I have been seeing an issue, where it would return False initially, but
later True; causing an `AttributeError` with the `mailoutbox` fixture,
because `mail.outbox` was not set on the module.

This can happen with imported code that changes the environment, e.g.
via "wsgi/asgi.py":

> os.environ.setdefault("DJANGO_SETTINGS_MODULE", "foo.settings")
    @blueyed
    blueyed committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    3212cc2 View commit details
    Browse the repository at this point in the history

  2. remove cache, use session-scoped fixture

    @blueyed
    blueyed committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    72d4f5b View commit details
    Browse the repository at this point in the history

  3. remove unused fixture args

    @blueyed
    blueyed committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    33282a8 View commit details
    Browse the repository at this point in the history

  4. django_mail_patch_dns: check _django_settings_is_configured:

    @blueyed
    blueyed committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    1161f10 View commit details
    Browse the repository at this point in the history

  5. doc

    @blueyed
    blueyed committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    74e310a View commit details
    Browse the repository at this point in the history