Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new option to avoid forcing of DEBUG setting to False #231

Merged
merged 1 commit into from Jul 26, 2015

Conversation

bubenkoff
Copy link
Member

closes #228

@bubenkoff bubenkoff changed the title Added a new option to avoid forcing of DEBUG setting to False. closes #... Added a new option to avoid forcing of DEBUG setting to False Apr 10, 2015
@bubenkoff bubenkoff assigned blueyed and pelme and unassigned blueyed Apr 11, 2015
@bubenkoff
Copy link
Member Author

@blueyed, @pelme
can you please review?

@blueyed
Copy link
Contributor

blueyed commented Apr 15, 2015

I find the option name confusing, because of the double negation.

Given that, I think it might be better to make the option control the DEBUG setting. Something like --django-debug, which would default to False (current behavior) and could be also True (enable debugging from pytest), or None (do not force setting/changing it).

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.13% when pulling 5297b81 on no-force-debug into 1f279de on master.

@blueyed
Copy link
Contributor

blueyed commented Apr 29, 2015

@bubenkoff
What's your opinion on my comment / feedback?

@bubenkoff
Copy link
Member Author

i agree, will change the PR

On 29/04/2015, Daniel Hahler notifications@github.com wrote:

@bubenkoff
What's your opinion on my comment / feedback?


Reply to this email directly or view it on GitHub:
#231 (comment)

Anatoly Bubenkov

@blueyed blueyed assigned bubenkoff and unassigned pelme May 8, 2015
@osantana
Copy link

👍

pelme added a commit that referenced this pull request Jul 26, 2015
Added a new option  to avoid forcing of DEBUG setting to False
@pelme pelme merged commit 73fe800 into master Jul 26, 2015
@pelme
Copy link
Member

pelme commented Jul 26, 2015

@bubenkoff Sorry for the delay, it is now merged, will hopefully put out a new release later today :)

@blueyed
Copy link
Contributor

blueyed commented Jul 26, 2015

@pelme
That should not have been merged yet: #231 (comment)

pelme added a commit that referenced this pull request Jul 26, 2015
This reverts commit 73fe800, reversing
changes made to fe7d280.
@pelme
Copy link
Member

pelme commented Jul 26, 2015

Oops, sorry about that, I have reverted the merge in 3cd0d32.

@pelme
Copy link
Member

pelme commented Jul 26, 2015

Meh. github won't allow re-opening a pull request. @bubenkoff can you please create a new PR? Sorry for the mess. :(

@bubenkoff
Copy link
Member Author

no problem

On Sun, Jul 26, 2015 at 8:53 PM Andreas Pelme notifications@github.com
wrote:

Meh. github won't allow re-opening a pull request. @bubenkoff
https://github.com/bubenkoff can you please create a new PR? Sorry for
the mess. :(


Reply to this email directly or view it on GitHub
#231 (comment)
.

@blueyed blueyed deleted the no-force-debug branch February 21, 2017 17:25
mfa pushed a commit to aexeagmbh/pytest-django that referenced this pull request May 17, 2017
…bug"

This reverts commit 73fe800, reversing
changes made to fe7d280.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

why DEBUG is hardcoded to False?
5 participants