fail-on-template-vars: be more discreet with ignore_template_errors #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavfernandez
force-pushed
the
silent_failure_when_ignoring_template_error
branch
from
28a0c76
to
f5c5f37
Compare
xavfernandez
force-pushed
the
silent_failure_when_ignoring_template_error
branch
from
f5c5f37
to
7f5e003
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
@pytest.mark.ignore_template_errorson a test, we could expect the test to return to its original behavior (just like running them without--fail-on-template-vars).This would ease the use of the option since ignored tests are less likely to crash.