Add Python 3.11 and PyPy 3.9 to the testing and drop 3.6 #567

cclauss · 2022-11-16T10:48:35Z

cclauss · 2022-12-03T11:13:36Z

@RonnyPfannschmidt @ssbarnea Can you please approve the workflow run so we can see if it passes?

ssbarnea · 2022-12-03T12:41:30Z

Is not a problem of approval, there is no option. Changes made to a workflow must come from another branch in the repository in order to be tested correctly by GHA. When they come from a pull-request, they are not applied as someone would expect.

hugovk · 2022-12-05T09:51:40Z

@cclauss The CI is failing.

Mason-Lin

Fixes some typos.

tox.ini

hugovk · 2023-02-19T08:07:46Z

https://github.com/pytest-dev/pytest-cov/actions/runs/4215078717/jobs/7315964982 is erroring because GitHub Actions is dropping support for EOL Python 3.6.

pytest itself dropped 3.6 in 2021: pytest-dev/pytest#9437

Mason-Lin · 2023-02-19T08:35:39Z

Need to update pytest-xdist >=3.1.0
#842: Python 3.11 is now officially supported.

https://pytest-xdist.readthedocs.io/en/latest/changelog.html#pytest-xdist-3-1-0-2022-12-01

Pierre-Sassoulas · 2023-02-19T11:55:44Z

@Mason-Lin There's no need to update pytest-xdist, pip will take the version compatible with the user interpreter (provided metadata are correct in pytest-xdist packaging). We might make the resolution impossible for lower interpreter version if we do that (i.e. no compatible pytest-xdist for python 3.7 or a false incompatibility with another dependencie that need an old pytest-xdist)

cclauss · 2023-02-19T12:57:41Z

@hugovk @Mason-Lin @Pierre-Sassoulas Your reviews, please.

Mason-Lin · 2023-02-19T13:17:00Z

@Mason-Lin There's no need to update pytest-xdist, pip will take the version compatible with the user interpreter (provided metadata are correct in pytest-xdist packaging). We might make the resolution impossible for lower interpreter version if we do that (i.e. no compatible pytest-xdist for python 3.7 or a false incompatibility with another dependencie that need an old pytest-xdist)

I originally saw pytest-xdist==3.0.2 in tox.ini. After checking the changelog, it seems that only 3.2.0 supports python 3.11.
I thought it was just a typo, I am not very familiar with this project.😅
The following commit done much more, such as skip boxed option.
Sorry for giving a wrong direction with a positive tone, I was really just guessing, thanks for the detailed explanation.

Pierre-Sassoulas

LGTM but it also remove pypy3.7 and python 3.9, I'm not familiar with the maintenance guideline of pytest-cov so I can't approve.

hugovk · 2023-02-19T13:40:21Z

.pre-commit-config.yaml

    hooks:
      - id: pyupgrade
-        args: [--py36-plus]
+        args: [--py37-plus]


If dropping 3.6, there's also the classifier and python_requires in setup.py. Plus mention in the PR title.

I think also need to update few parts related to Python 3.6 if this PR is going to drop 3.6.

https://github.com/pytest-dev/pytest-cov/blob/master/setup.py#L114

Done below.

Let's also mention the 3.6 drop in the PR title for visibility/transparency.

cclauss · 2023-02-19T13:57:06Z

The pypy team dropped pypy3.7 https://www.pypy.org/download.html

hugovk · 2023-02-19T14:26:29Z

tests/test_pytest_cov.py

@@ -1916,6 +1918,7 @@ def find_labels(text, pattern):


 @pytest.mark.skipif("coverage.version_info < (5, 0)")
+@pytest.mark.skipif("coverage.version_info > (6, 4)")


What's the reason for skipping coverage > 6.4?

Newer output adds lines for test setup and teardown.

https://github.com/pytest-dev/pytest-cov/actions/runs/4216048632/jobs/7317609380

hugovk · 2023-02-19T14:28:08Z

.github/workflows/test.yml

+            toxpython: 'python3.11'
+            python_arch: 'x64'
+            tox_env: 'py311-pytest72-xdist320-coverage65'
+            os: 'macos-latest'
          - name: 'pypy37-pytest71-xdist250-coverage64 (ubuntu)'


Re: PyPy dropping PyPy3.7 (https://www.pypy.org/posts/2022/12/pypy-v7311-release.html), should we remove these three pypy-3.7 jobs?

I am willing to go either way.

Pierre-Sassoulas · 2023-02-27T12:52:54Z

tox.ini

    check-manifest
+    colorama


Why do we need to add colorama ?

https://github.com/pytest-dev/pytest-cov/actions/runs/4284044499/jobs/7460448953

For future reference, when the GHA log is deleted:

check: commands[3]> isort --check-only --diff src tests setup.py Traceback (most recent call last): File "/home/runner/work/pytest-cov/pytest-cov/.tox/check/lib/python3.11/site-packages/isort/main.py", line 87, in sort_imports incorrectly_sorted = not api.check_file(file_name, config=config, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/runner/work/pytest-cov/pytest-cov/.tox/check/lib/python3.11/site-packages/isort/api.py", line [33](https://github.com/pytest-dev/pytest-cov/actions/runs/4284044499/jobs/7460448953#step:5:34)8, in check_file return check_stream( ^^^^^^^^^^^^^ File "/home/runner/work/pytest-cov/pytest-cov/.tox/check/lib/python3.11/site-packages/isort/api.py", line 272, in check_stream printer = create_terminal_printer( ^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/runner/work/pytest-cov/pytest-cov/.tox/check/lib/python3.11/site-packages/isort/format.py", line 153, in create_terminal_printer colorama.init(strip=False) ^^^^^^^^ NameError: name 'colorama' is not defined During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/runner/work/pytest-cov/pytest-cov/.tox/check/bin/isort", line 8, in <module> sys.exit(main()) ^^^^^^ File "/home/runner/work/pytest-cov/pytest-cov/.tox/check/lib/python3.11/site-packages/isort/main.py", line 1225, in main for sort_attempt in attempt_iterator: File "/home/runner/work/pytest-cov/pytest-cov/.tox/check/lib/python3.11/site-packages/isort/main.py", line 1209, in <genexpr> sort_imports( # type: ignore File "/home/runner/work/pytest-cov/pytest-cov/.tox/check/lib/python3.11/site-packages/isort/main.py", line 114, in sort_imports _print_hard_fail(config, offending_file=file_name) File "/home/runner/work/pytest-cov/pytest-cov/.tox/check/lib/python3.11/site-packages/isort/main.py", line 127, in _print_hard_fail printer = create_terminal_printer( ^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/runner/work/pytest-cov/pytest-cov/.tox/check/lib/python3.11/site-packages/isort/format.py", line 1[53](https://github.com/pytest-dev/pytest-cov/actions/runs/4284044499/jobs/7460448953#step:5:54), in create_terminal_printer colorama.init(strip=False) ^^^^^^^^ NameError: name 'colorama' is not defined check: exit 1 (0.09 seconds) /home/runner/work/pytest-cov/pytest-cov> isort --check-only --diff src tests setup.py pid=1722 check: FAIL code 1 (7.13=setup[4.74]+cmd[0.[58](https://github.com/pytest-dev/pytest-cov/actions/runs/4284044499/jobs/7460448953#step:5:59),0.79,0.94,0.09] seconds) evaluation failed :( (7.19 seconds) Error: Process completed with exit code 1.

This looks like something that should be fixed upstream in isort rather than adding extra dependencies here.

We're installing isort 6.0.0b2 (released Dec 12, 2022) but looks like it was fixed in PyCQA/isort#2032, merged Dec 12, 2022, which looks like it was only released in 5.11.1 (also Dec 12, 2022) - but there's no tags for the 6.x beta releases so it's hard to check.

Anyway, I asked in that PR if they can release a 6.x beta with the fix, then we can remove this extra dependency.

Alternatively, we could test on the non-prerelease isort, but I don't know the original reasons for that, so maybe better to keep it.

Comment added.

Pierre-Sassoulas · 2023-02-27T12:54:29Z

.github/workflows/test.yml

@@ -6,25 +6,25 @@ jobs:
    strategy:
      fail-fast: false
      matrix:
-        python-version: ["pypy-3.7", "3.9"]
+        python-version: ["pypy-3.9", "3.11"]


Shouldn't it be pypy 3.8 (3.7 was dropped but the lower bound seems to be 3.8 not 3.9) ?

These are UPPER bounds, not lower bounds.

I thought it was lower bound (3.7) and upper bound (3.9). Wouldn't we use 3.9 only if it was upper bounds ?

tox.ini

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

ssbarnea added the skip-changelog label Dec 3, 2022

ssbarnea approved these changes Dec 3, 2022

View reviewed changes

Mason-Lin reviewed Feb 19, 2023

View reviewed changes

tox.ini Outdated Show resolved Hide resolved

tox.ini Outdated Show resolved Hide resolved

cclauss force-pushed the patch-1 branch 2 times, most recently from e34d9e7 to 4f71782 Compare February 19, 2023 11:29

Pierre-Sassoulas reviewed Feb 19, 2023

View reviewed changes

hugovk reviewed Feb 19, 2023

View reviewed changes

Mason-Lin approved these changes Feb 19, 2023

View reviewed changes

hugovk reviewed Feb 19, 2023

View reviewed changes

hugovk mentioned this pull request Feb 27, 2023

Add support for JSON reporter #582

Closed

Pierre-Sassoulas reviewed Feb 27, 2023

View reviewed changes

Add Python 3.11 and PyPy 3.9 to the testing

fceb9ea

cclauss force-pushed the patch-1 branch from a308883 to fceb9ea Compare February 27, 2023 15:37

Fixes from code reviews

8b6de35

cclauss requested review from hugovk and Pierre-Sassoulas and removed request for hugovk and Pierre-Sassoulas February 28, 2023 06:03

colorama # Remove when isort > v5.12.0 is released.

1cefc21

hugovk reviewed Feb 28, 2023

View reviewed changes

tox.ini Outdated Show resolved Hide resolved

Update tox.ini

1e79cca

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

cclauss mentioned this pull request Feb 28, 2023

pre-commit: Replace flake8, isort, and pyupgrade with ruff #584

Closed

hugovk changed the title ~~Add Python 3.11 and PyPy 3.9 to the testing~~ Add Python 3.11 and PyPy 3.9 to the testing and drop 3.6 Feb 28, 2023

hugovk approved these changes Feb 28, 2023

View reviewed changes

RonnyPfannschmidt approved these changes Feb 28, 2023

View reviewed changes

Pierre-Sassoulas approved these changes Feb 28, 2023

View reviewed changes

Pierre-Sassoulas merged commit d9789af into pytest-dev:master Feb 28, 2023

cclauss deleted the patch-1 branch February 28, 2023 12:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Python 3.11 and PyPy 3.9 to the testing and drop 3.6 #567

Add Python 3.11 and PyPy 3.9 to the testing and drop 3.6 #567

cclauss commented Nov 16, 2022 •

edited

cclauss commented Dec 3, 2022

ssbarnea commented Dec 3, 2022

hugovk commented Dec 5, 2022

Mason-Lin left a comment

hugovk commented Feb 19, 2023

Mason-Lin commented Feb 19, 2023

Pierre-Sassoulas commented Feb 19, 2023

cclauss commented Feb 19, 2023

Mason-Lin commented Feb 19, 2023

Pierre-Sassoulas left a comment

hugovk Feb 19, 2023

Mason-Lin Feb 19, 2023

cclauss Feb 27, 2023 •

edited

hugovk Feb 28, 2023

cclauss commented Feb 19, 2023

hugovk Feb 19, 2023

cclauss Feb 19, 2023 •

edited

hugovk Feb 19, 2023

cclauss Feb 19, 2023

cclauss Feb 28, 2023

Pierre-Sassoulas Feb 27, 2023

cclauss Feb 27, 2023

hugovk Feb 28, 2023

hugovk Feb 28, 2023

cclauss Feb 28, 2023

Pierre-Sassoulas Feb 27, 2023

cclauss Feb 27, 2023

Pierre-Sassoulas Feb 28, 2023

		@@ -1916,6 +1918,7 @@ def find_labels(text, pattern):


		@pytest.mark.skipif("coverage.version_info < (5, 0)")
		@pytest.mark.skipif("coverage.version_info > (6, 4)")

Add Python 3.11 and PyPy 3.9 to the testing and drop 3.6 #567

Add Python 3.11 and PyPy 3.9 to the testing and drop 3.6 #567

Conversation

cclauss commented Nov 16, 2022 • edited

cclauss commented Dec 3, 2022

ssbarnea commented Dec 3, 2022

hugovk commented Dec 5, 2022

Mason-Lin left a comment

Choose a reason for hiding this comment

hugovk commented Feb 19, 2023

Mason-Lin commented Feb 19, 2023

Pierre-Sassoulas commented Feb 19, 2023

cclauss commented Feb 19, 2023

Mason-Lin commented Feb 19, 2023

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cclauss Feb 27, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cclauss commented Feb 19, 2023

Choose a reason for hiding this comment

cclauss Feb 19, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cclauss commented Nov 16, 2022 •

edited

cclauss Feb 27, 2023 •

edited

cclauss Feb 19, 2023 •

edited