Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on GitHub Actions #494
Test on GitHub Actions #494
Changes from 4 commits
db5d7c9
3490ccb
f81aa0c
71976eb
a948e89
f4a88d6
6395ece
96f9aad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason for publishing the github workflow to pypi? they both use
actions/checkout@v2
which won't work without a live git repo and can't work from the sdistThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the reason is
.travis.yml .appveyor.yml
were/is included below, so I was aiming for parity.Can remove if you like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the best option here is.
I assume all these includes come as a result of
check-manifest
's default recommendation of including files rather than excluding them. I think using the "wheel_from_sdist",build
strategy and then using that wheel in tox is the state of the art for ensuring your MANIFEST is correct pypa/build#257another option is to follow pytest-dev/pytest's approach of using setuptools-scm, which makes the MANIFEST.in redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong opinion here, although I use setuptools-scm elsewhere and it makes things easy. Something for a followup issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fair to include it in the sdist, considering travis stuff was previously included, and it would be useful to have some evidence in the sdist of how that particular release was supposed to be tested.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a CI recommendation and coverage provider recommendation, perhaps more tools could go here? Or pytest-cov could collect sponsorship to recommend a specific CI provider and coverage provider?
eg GitLab has integrated support for coverage files (and recommend pytest-cov!) https://docs.gitlab.com/ee/user/project/merge_requests/test_coverage_visualization.html#python-example
just a heads up: no need to worry about this now in this PR though imho