Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison against installed PyTest version #354

Merged
merged 3 commits into from Nov 2, 2019
Merged

Fix comparison against installed PyTest version #354

merged 3 commits into from Nov 2, 2019

Commits on Oct 26, 2019

  1. Fix comparison against installed PyTest version 

    With the current code, introduced in pytest-dev#230, the comparison
`pytest.__version__ >= '3.8'` returns the wrong result when using
PyTest 3.10, as `'3.10' < '3.8'` if we use Python's string comparison.

Having `PYTEST_VERSION` as an integer tuple allows us to have simpler
comparisons.

This fixes the following warning when using PyTest 3.10:
```
RemovedInPytest4Warning: config.warn has been deprecated, use warnings.warn instead
```
    @adamantike
    adamantike committed Oct 26, 2019
    Copy the full SHA
    644d3c0 View commit details
    Browse the repository at this point in the history

  2. Fix linting issues

    @adamantike
    adamantike committed Oct 26, 2019
    Copy the full SHA
    d418d47 View commit details
    Browse the repository at this point in the history

  3. Update changelog and authors file

    @adamantike
    adamantike committed Oct 26, 2019
    Copy the full SHA
    b6e4b9a View commit details
    Browse the repository at this point in the history