Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove multiprocess finalizer and improve subprocess docs #265

Merged
merged 34 commits into from Mar 9, 2019
Merged

Remove multiprocess finalizer and improve subprocess docs #265

merged 34 commits into from Mar 9, 2019

Commits on Feb 16, 2019

  1. Stop using multiprocess finalizers. Better document workarounds for u… 

    …nclean subprocess exits.
    @ionelmc
    ionelmc committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    3160976 View commit details
    Browse the repository at this point in the history

  2. Rename file.

    @ionelmc
    ionelmc committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    1210cdc View commit details
    Browse the repository at this point in the history

  3. Update docs/subprocess-support.rst 

    Co-Authored-By: ionelmc <contact@ionelmc.ro>
    @blueyed @ionelmc
    blueyed and ionelmc committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    0533855 View commit details
    Browse the repository at this point in the history

  4. Update docs/subprocess-support.rst 

    Co-Authored-By: ionelmc <contact@ionelmc.ro>
    @blueyed @ionelmc
    blueyed and ionelmc committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    892f4e1 View commit details
    Browse the repository at this point in the history

  5. Update docs/subprocess-support.rst 

    Co-Authored-By: ionelmc <contact@ionelmc.ro>
    @blueyed @ionelmc
    blueyed and ionelmc committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    b494c37 View commit details
    Browse the repository at this point in the history

  6. Remove the note about windows completely.

    @ionelmc
    ionelmc committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    5d49467 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2019

  1. Well ... bring back the finalizer, but make the cleanup reentrant.

    @ionelmc
    ionelmc committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    1cb8ce6 View commit details
    Browse the repository at this point in the history

  2. Remove this attribute and rely on pytest_cov.embed's internal storage… 

    …. Fixes regression (cleanup don't take no argument no more).
    @ionelmc
    ionelmc committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    8014767 View commit details
    Browse the repository at this point in the history

  3. Ignore SIG_DFL (lil regression).

    @ionelmc
    ionelmc committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    38c89a8 View commit details
    Browse the repository at this point in the history

  4. Avoid doubly registering the signal handler (so the previous handler … 

    …is not lost).
    @ionelmc
    ionelmc committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    5374581 View commit details
    Browse the repository at this point in the history

  5. Add missing global.

    @ionelmc
    ionelmc committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    710e4cc View commit details
    Browse the repository at this point in the history

  6. Add a test for #250.

    @ionelmc
    ionelmc committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    8a2bfa8 View commit details
    Browse the repository at this point in the history

  7. Add a windows specific test.

    @ionelmc
    ionelmc committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    4046fc2 View commit details
    Browse the repository at this point in the history

  8. Some renaming to better reflect what is actually tested.

    @ionelmc
    ionelmc committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    65d50cf View commit details
    Browse the repository at this point in the history

  9. Add few more multiprocessing tests and change some details for skips.

    @ionelmc
    ionelmc committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    49f55d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2019

  1. Skip a bunch of stuff on windows+pypy - it's broken, see pytest-dev/p… 

    …ytest-xdist#142
    @ionelmc
    ionelmc committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    b449d92 View commit details
    Browse the repository at this point in the history

  2. Correct some assertions. Revert bogus change.

    @ionelmc
    ionelmc committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    c32c158 View commit details
    Browse the repository at this point in the history

  3. Run this fewer times. Maybe travis too slow for such heavy test.

    @ionelmc
    ionelmc committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    ab9d7bc View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2019

  1. Rework a bit the mp pool integration tests to generate a line of code… 

    … for each iteration (more precise). Also spawns a bit less workers.
    @ionelmc
    ionelmc committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    cd0c4a4 View commit details
    Browse the repository at this point in the history

  2. Some cleanup.

    @ionelmc
    ionelmc committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    3d3b488 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2019

  1. Skip this on windows/pypy (xdist broken).

    @ionelmc
    ionelmc committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    2291d76 View commit details
    Browse the repository at this point in the history

  2. Extend assertion a bit.

    @ionelmc
    ionelmc committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    8f1b9e6 View commit details
    Browse the repository at this point in the history

  3. Change the docs again to reflect the current implementation.

    @ionelmc
    ionelmc committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    478152e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2019

  1. Fix escaping.

    @ionelmc
    ionelmc committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    7aa50d9 View commit details
    Browse the repository at this point in the history

  2. Use travis_wait (mainly for pypy which often times out).

    @ionelmc
    ionelmc committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    3709127 View commit details
    Browse the repository at this point in the history

  3. Use travispls instead - travis_wait is so broken ...

    @ionelmc
    ionelmc committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    35f38f4 View commit details
    Browse the repository at this point in the history

  4. Don't run pypy3 on Windows.

    @ionelmc
    ionelmc committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    bcdce59 View commit details
    Browse the repository at this point in the history

  5. Skip the terminate tests on PyPy and remove travispls (doesn't work o… 

    …n Python2).
    @ionelmc
    ionelmc committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    c11fe04 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2019

  1. Remove the automatic SIGTERM handler install from the afterfork 

    handler and update docs.

The reason for this change being that multiprocessing
is going to be broken on windows or pypy anyway, so this is best left to
the users to deal in their own code. The documentation includes a
working pattern to use (close/join). If the users really needs to use
terminate then they should have a platform check and compromise between
lower coverage measurement on pypy or chance to deadlock (as seen in the
travis failures in #265).
    @ionelmc
    ionelmc committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    103d1ef View commit details
    Browse the repository at this point in the history

  2. Avoid having stray tracers around. This fixes an "AssertionError: Exp… 

    …ected current collector to be <Collector at ...: CTracer>, but it's <Collector at ...: CTracer>" error (caused by the embed.cleanup running way too late).
    @ionelmc
    ionelmc committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    66d8ade View commit details
    Browse the repository at this point in the history

  3. Avoid writing bogus data files from dead coverage tracers.

    @ionelmc
    ionelmc committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    65959fc View commit details
    Browse the repository at this point in the history

  4. Allow COV_CORE_SOURCE to be empty (it'd be converted to None). Also u… 

    …pdate docs regarding using pytest-cov with other pytest plugins.
    @ionelmc
    ionelmc committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    fdc43ec View commit details
    Browse the repository at this point in the history

  5. Fix cleanup leaving unusable state.

    @ionelmc
    ionelmc committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    7557f67 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2019

  1. Always skip this on PyPy as it sometimes fail with `error: release un… 

    …locked lock` and the goal of this test was rather to assert that combining is done in the right place not that xdist works well on pypy.

The traceback:

    /home/travis/pypy2-v6.0.0-linux64/lib-python/2.7/logging/__init__.py:846: in __init__
        Handler.__init__(self)
    /home/travis/pypy2-v6.0.0-linux64/lib-python/2.7/logging/__init__.py:688: in __init__
        _addHandlerRef(self)
    /home/travis/pypy2-v6.0.0-linux64/lib-python/2.7/logging/__init__.py:667: in _addHandlerRef
        _releaseLock()
    /home/travis/pypy2-v6.0.0-linux64/lib-python/2.7/logging/__init__.py:232: in _releaseLock
        _lock.release()
    @ionelmc
    ionelmc committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    42f0307 View commit details
    Browse the repository at this point in the history