Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use deprecated config.warn #230

Merged
merged 3 commits into from Nov 15, 2018
Merged

Don't use deprecated config.warn #230

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aeef6d4
Don't use deprecated config.warn
MarSoft Sep 23, 2018
a14595f
Fix call to warnings.warn
nicoddemus Sep 24, 2018
325ab2e
Use warnings.warn only for pytest >= 3.8
nicoddemus Sep 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/pytest_cov/plugin.py
View file
Open in desktop
@@ -1,5 +1,6 @@
"""Coverage plugin for pytest."""
import os
import warnings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also be made conditional (if pytest.__version__ >= '3.8':).


import pytest
import argparse
Expand Down Expand Up @@ -234,7 +235,10 @@ def pytest_runtestloop(self, session):
message = 'Failed to generate report: %s\n' % exc
session.config.pluginmanager.getplugin("terminalreporter").write(
'WARNING: %s\n' % message, red=True, bold=True)
session.config.warn(code='COV-2', message=message)
if pytest.__version__ >= '3.8':
warnings.warn(pytest.PytestWarning(message))
else:
session.config.warn(code='COV-2', message=message)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to have this pattern in the deprecation docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, done: pytest-dev/pytest#4029

self.cov_total = 0
assert self.cov_total is not None, 'Test coverage should never be `None`'
if self._failed_cov_total():
Expand All @@ -245,7 +249,10 @@ def pytest_terminal_summary(self, terminalreporter):
if self._disabled:
message = 'Coverage disabled via --no-cov switch!'
terminalreporter.write('WARNING: %s\n' % message, red=True, bold=True)
terminalreporter.config.warn(code='COV-1', message=message)
if pytest.__version__ >= '3.8':
warnings.warn(pytest.PytestWarning(message))
else:
terminalreporter.config.warn(code='COV-1', message=message)
return
if self.cov_controller is None:
return
Expand Down