Skip to content

Commit

Permalink
Make changes requested in code review
Browse files Browse the repository at this point in the history
  • Loading branch information
cclauss committed Mar 20, 2023
1 parent 4200898 commit d5a6605
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 24 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ repos:
rev: v0.0.253
hooks:
- id: ruff
# args: [--fix, --exit-non-zero-on-fix]
args: [--fix, --exit-non-zero-on-fix, --show-fixes]
32 changes: 23 additions & 9 deletions .ruff.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,30 @@ exclude = [
"ci/templates",
"dist",
]
line-length = 140
select = [
"E",
"F",
"I",
"PLC",
"PLE",
"UP",
"W",
ignore = [
"D", # pydocstyle
"ANN", # flake8-annotations
"ARG", # flake8-unused-arguments
"BLE", # flake8-blind-except
"C90", # mccabe
"EM", # flake8-errmsg
"FBT", # flake8-boolean-trap
"INP", # flake8-no-pep420
"PLR", # Pylint Refactor
"PLW", # Pylint Warning
"Q", # flake8-quotes
"RET", # flake8-return
"SIM102", # flake8-simplify collapsible-if
"SIM105", # flake8-simplify use-contextlib-suppress
"SLF", # flake8-self
"T20", # flake8-print
"S101", # flake8-bandit assert
"S102", # flake8-bandit exec
"S110", # flake8-bandit try-except-pass
"TRY", # tryceratops
]
line-length = 140
select = ["ALL"]
target-version = "py37"

# [tool.ruff.isort] # <- TODO Uncomment when migrating to pyproject.toml
Expand Down
12 changes: 0 additions & 12 deletions setup.cfg
Original file line number Diff line number Diff line change
@@ -1,19 +1,7 @@
[flake8]
max-line-length = 140
exclude = .tox,.eggs,ci/templates,build,dist

[tool:pytest]
testpaths = tests
python_files = test_*.py
addopts =
-ra
--strict
-p pytester

[tool:isort]
force_single_line = True
line_length = 120
known_first_party = pytest_cov
default_section = THIRDPARTY
forced_separate = test_pytest_cov
skip = .tox,.eggs,ci/templates,build,dist
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,14 @@ deps =
check-manifest
colorama # TODO Remove when isort > v6.0.0b2 is released.
docutils
flake8
isort
pygments
readme-renderer
ruff
skip_install = true
usedevelop = false
commands =
python setup.py check --strict --metadata --restructuredtext
check-manifest {toxinidir}
flake8 src tests setup.py
ruff .
isort --check-only --diff src tests setup.py

0 comments on commit d5a6605

Please sign in to comment.