Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on glob2 #570

Merged
merged 1 commit into from Nov 3, 2022
Merged

Drop dependency on glob2 #570

merged 1 commit into from Nov 3, 2022

Conversation

drothlis
Copy link
Contributor

@drothlis drothlis commented Nov 3, 2022

The standard library's glob supports "**" since Python 3.5. pytest-bdd requires Python >= 3.7.

TODO:

@drothlis
Copy link
Contributor Author

drothlis commented Nov 3, 2022

CI failure against pytest-latest:

INTERNALERROR>     tw = py.io.TerminalWriter()
INTERNALERROR> AttributeError: module 'py' has no attribute 'io'

It's unrelated to this pull request. pytest 7.2.0 (2022-10-23) release notes say:

#10396: pytest no longer depends on the py library. pytest provides a vendored copy of py.error and py.path modules but will use the py library if it is installed. If you need other py.* modules, continue to install the deprecated py library separately, otherwise it can usually be removed as a dependency.

Edit: Fixed in #571.

The standard library's `glob` supports "**" since Python 3.5.
pytest-bdd requires Python >= 3.7.
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 98.49% // Head: 98.49% // No change to project coverage 👍

Coverage data is based on head (8123f7a) compared to base (33fbca4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #570   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files          32       32           
  Lines         733      733           
  Branches       16       16           
=======================================
  Hits          722      722           
  Misses          9        9           
  Partials        2        2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@drothlis drothlis requested a review from youtux November 3, 2022 21:29
@youtux youtux merged commit 3f6dc87 into pytest-dev:master Nov 3, 2022
@drothlis drothlis deleted the drop-glob2 branch November 3, 2022 21:43
toofar added a commit to qutebrowser/qutebrowser that referenced this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants