Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations #505

Merged
merged 39 commits into from
Mar 5, 2022
Merged

Add type annotations #505

merged 39 commits into from
Mar 5, 2022

Conversation

youtux
Copy link
Contributor

@youtux youtux commented Mar 3, 2022

Add type annotations to the codebase, and add a CI step to run mypy (for now we let it fail, as fixing those failures would require even more time)

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #505 (e378ccb) into master (ddcbeb5) will decrease coverage by 2.71%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
- Coverage   95.40%   92.69%   -2.72%     
==========================================
  Files          48       48              
  Lines        1566     1642      +76     
  Branches      166      176      +10     
==========================================
+ Hits         1494     1522      +28     
- Misses         45       82      +37     
- Partials       27       38      +11     
Impacted Files Coverage Δ
pytest_bdd/gherkin_terminal_reporter.py 75.71% <61.53%> (-4.94%) ⬇️
pytest_bdd/generation.py 83.48% <63.63%> (-6.21%) ⬇️
pytest_bdd/plugin.py 83.87% <66.66%> (-14.13%) ⬇️
tests/utils.py 84.61% <66.66%> (-15.39%) ⬇️
tests/feature/test_cucumber_json.py 92.59% <71.42%> (-7.41%) ⬇️
pytest_bdd/cucumber_json.py 86.36% <72.72%> (-6.97%) ⬇️
pytest_bdd/reporting.py 78.68% <74.07%> (-9.78%) ⬇️
pytest_bdd/utils.py 87.09% <77.77%> (-5.77%) ⬇️
pytest_bdd/scenario.py 89.53% <84.37%> (-1.49%) ⬇️
pytest_bdd/parsers.py 88.00% <85.71%> (-7.66%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddcbeb5...e378ccb. Read the comment docs.

@youtux youtux merged commit 02bf620 into master Mar 5, 2022
@youtux youtux deleted the add-type-annotations branch March 5, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant