Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature examples removal. Compatibility with official gherkin #490

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

olegpidsadnyi
Copy link
Contributor

Gherkin 6 is becoming more complex. In order to be compatible with all the changes like multiple scenario examples we should remove our own complexity.
The spirit of pytest-bdd 6 would be gherkin compatibility.
This PR is removing the examples on the feature level.

@olegpidsadnyi olegpidsadnyi self-assigned this Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #490 (cc528b9) into master (f4ed62d) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
- Coverage   95.91%   95.86%   -0.05%     
==========================================
  Files          49       49              
  Lines        1640     1621      -19     
  Branches      179      177       -2     
==========================================
- Hits         1573     1554      -19     
  Misses         41       41              
  Partials       26       26              
Impacted Files Coverage Δ
tests/feature/test_outline.py 100.00% <ø> (ø)
pytest_bdd/__init__.py 100.00% <100.00%> (ø)
pytest_bdd/parser.py 99.53% <100.00%> (-0.01%) ⬇️
pytest_bdd/scenario.py 91.56% <100.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ed62d...cc528b9. Read the comment docs.

@olegpidsadnyi olegpidsadnyi merged commit e0a1437 into master Jan 15, 2022
@olegpidsadnyi olegpidsadnyi deleted the feature-examples-removal branch January 15, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant