Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI linting workflow #308

Merged
merged 5 commits into from Mar 11, 2022
Merged

Fix CI linting workflow #308

merged 5 commits into from Mar 11, 2022

Commits on Mar 11, 2022

  1. ci: No longer fail silently when the expected Python interpreter is m… 

    …issing.

 The tox "lint" target expects Python 3.10 to be installed, but CI only installs Python 3.9. skip_missing_interpreters caused the "lint" workflow in CI to exit successfully, even though no linting was performed.

Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
    @seifertm
    seifertm committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    dc14d8c View commit details
    Browse the repository at this point in the history

  2. ci: Install Python 3.10 for the "lint" workflow, as expected by the t… 

    …ox configuration.

Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
    @seifertm
    seifertm committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    90732cb View commit details
    Browse the repository at this point in the history

  3. ci: Do not inlcude tox's "lint" environment in the set of "3.9" envir… 

    …onments of a GitHub actions run.

Linting is performed explicitly in a separate workflow and does not need to be run as part of the Python 3.9 tests. Additionally, linting currently expects Python 3.10 and will fail during the Python 3.9 test run.

Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
    @seifertm
    seifertm committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    2878c59 View commit details
    Browse the repository at this point in the history

  4. build: Dependencies for tox's "lint" environent are installed correctly. 

    The lint environment requires mypy from the test dependencies to be installed. Although the environment defines `extras = testing`, it also specifies `skip_install = true`, which also skips installation of test dependencies.

This change removes skip_install = true, so that mypy is installed correctly.

Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
    @seifertm
    seifertm committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    46a95fb View commit details
    Browse the repository at this point in the history

  5. build: Removed the explicit interpreter version dependency from tox's… 

    … "version-info" environment.

Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
    @seifertm
    seifertm committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    f8eb9ef View commit details
    Browse the repository at this point in the history