Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't close event loop if the loop doesn't exist #261

Merged
merged 2 commits into from Jan 15, 2022

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Jan 14, 2022

Fixes #257

@codecov-commenter
Copy link

Codecov Report

Merging #261 (953d9a1) into master (6cc430c) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   92.98%   93.13%   +0.15%     
==========================================
  Files           3        3              
  Lines         228      233       +5     
  Branches       32       33       +1     
==========================================
+ Hits          212      217       +5     
  Misses         10       10              
  Partials        6        6              
Impacted Files Coverage Δ
plugin.py 92.98% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc430c...953d9a1. Read the comment docs.

@asvetlov
Copy link
Contributor Author

Ready for review, tests are green

@zanieb
Copy link

zanieb commented Jan 14, 2022

Thanks! This implementation lgtm

@asvetlov asvetlov merged commit 0a3328f into pytest-dev:master Jan 15, 2022
@asvetlov asvetlov deleted the post-close branch January 15, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event loop shutdown failures on 0.17
4 participants