Put @pytest.mark.asyncio decorators back in for now
#4598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting conflict with pytest-tornasync after removing `@pytest.mark.asyncio` decorators - eukaryote/pytest-tornasync#13 Partial revert of 7b4e95c, reversing changes made to eb2e4fd.
MetRonnie
changed the title
@pytest.mark.asyncio decorators back in for now
|
I think I've got an alternative that disables the pytest_tornasync plugin to prevent it from interfering so we can keep your earlier changes. |
|
Superseded by #4599 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, now getting a conflict with pytest-tornasync after removing
@pytest.mark.asynciodecorators - eukaryote/pytest-tornasync#13. pytest-tornasync is a dependency of cylc-uiserver, not cylc-flow, so it passed on GH Actions but now flakily fails locally.This might be fixed by pytest-dev/pytest-asyncio#261 when it makes its way into a release
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.