Encapsulate spec definitions with a class #57

goodboy · 2017-07-07T23:16:09Z

Allows for easier introspection of spec definitions including function
signatures and hook options. Originally introduced to address ~~#47~~ #15 and #43 which
requires keeping track of spec default arguments values.

nicoddemus

Nice, but the issue number you mention (#47) is about the README. 😉

goodboy · 2017-07-08T03:54:52Z

@nicoddemus hah nice catch.
Yeah it's actually #15 and the accompanying PR #43.
I'll change the commit msg.

RonnyPfannschmidt

I suspekt if i had my computer on me I'd find anissie

Something about it irks me

goodboy · 2017-07-10T05:43:55Z

@RonnyPfannschmidt yeah if you find anything let me know.

This isn't really all that important if you don't like it.
I just thought I'd grab the handy stuff from #43 which might make somone's life easier down the road.

RonnyPfannschmidt · 2017-08-26T12:09:19Z

well, i fail to see it atm, lets go ahead with it

goodboy · 2017-08-29T00:25:34Z

@RonnyPfannschmidt we can always leave this sitting until we need it.
It's really only useful if we plan to introspect hookspec func signatures in the future.

goodboy · 2018-08-08T17:18:02Z

@fschulze take a look at this if you don't mind so we can figure out if it's going to meet your needs.
With this you can introspect spec args (and other things) using pm.hook.<hookname>.spec.

fschulze · 2018-08-08T17:50:52Z

edit: sorry to have added this comment on this not entirely related PR, I thought I was replying on #170.

@tgoodlet

@fschulze take a look at this if you don't mind so we can figure out if it's going to meet your needs.
With this you can introspect spec args (and other things) using pm.hook..spec.

That again is from the host side, do you have anything in mind for the plugin side? Is that even possible?

I still think my proposal like this would be simpler:

Host side:

@hookspec(deprecated=True)
def myhost_oldhook(...):
    ...

@hookspec(replaces=myhost_oldhook)
def myhost_newhook(...):
    ...

Plugin side:

@hookimpl(optional=True)
def myhost_oldhook(...):
    ...

@hookimpl(optional=True)
def myhost_newhook(...):
    ...

Pluggy would then remove myhost_oldhook from the list. This way all the following work:

old host - old plugin
new host - old plugin (with deprecation warning)
old host - new plugin (because the hook impl is optional)
new host - new plugin (because pluggy removes the old hook impl from the list and new host only calls the new hook of the plugin)

fschulze · 2018-08-08T17:57:23Z

This PR would make implementing my above proposal for #170 much simpler though.

RonnyPfannschmidt · 2018-08-16T05:22:57Z

pluggy/hooks.py

@@ -273,8 +267,10 @@ def __call__(self, *args, **kwargs):
        if args:
            raise TypeError("hook calling supports only keyword arguments")
        assert not self.is_historic()
-        if self.argnames:
-            notincall = set(self.argnames) - set(["__multicall__"]) - set(kwargs.keys())
+        if self.spec:


for parity this should be self.spec.argnames

good call - this looks like a mistake/typo

fschulze · 2018-08-16T06:08:16Z

pluggy/hooks.py

            self.set_specification(specmodule_or_class, spec_opts)

    def has_spec(self):
-        return self._specmodule_or_class is not None
+        return True if self.spec is not None else False


Why not just return self.spec is not None? Much easier to read than the trinary operator.

Heh, indeed!

goodboy · 2018-08-16T06:14:36Z

@RonnyPfannschmidt @fschulze changes addressed!

Btw @fschulze we've been having a discussion on gitter regarding the original problem.

Allows for easier introspection of spec definitions including function signatures and hook options. Originally introduced to address pytest-dev#15 and the accompanying PR (pytest-dev#43) which requires keeping track of spec default arguments values.

fschulze · 2018-08-16T06:56:48Z

@tgoodlet the conclusion of that discussion leads to my proposal again to allow deprecation of old hooks without double calls

goodboy · 2018-08-16T16:34:20Z

@fschulze yup just keeping you in the loop :)

nicoddemus · 2018-08-18T23:20:44Z

What else is needed to merge this?

goodboy · 2018-08-19T02:45:41Z

pluggy/manager.py

@@ -215,10 +217,10 @@ def _verify_hook(self, hook, hookimpl):
                "Plugin %r\nhook %r\nhistoric incompatible to hookwrapper"
                % (hookimpl.plugin_name, hook.name),
            )
-        if hook.warn_on_impl:
-            _warn_for_function(hook.warn_on_impl, hookimpl.function)
+        if hook.spec.warn_on_impl:


I feel like there'll be a bug here if there's no spec.

Wait, nm. This is never called unless a spec exists.

goodboy · 2018-08-19T16:22:14Z

@nicoddemus do you think we should document this as well or just leave as an internal until more people ask for it?

nicoddemus · 2018-08-28T15:59:31Z

@nicoddemus do you think we should document this as well or just leave as an internal until more people ask for it?

I think we can keep this an internal detail for now (sorry for the delay)

1594: Scheduled weekly dependency update for week 42 r=mythmon a=pyup-bot ### Update [botocore](https://pypi.org/project/botocore) from **1.12.23** to **1.12.28**. <details> <summary>Changelog</summary> ### 1.12.28 ``` ======= * api-change:``workspaces``: Update workspaces client to latest version * api-change:``ssm``: Update ssm client to latest version ``` ### 1.12.27 ``` ======= * api-change:``medialive``: Update medialive client to latest version * api-change:``route53``: Update route53 client to latest version * api-change:``appstream``: Update appstream client to latest version ``` ### 1.12.26 ``` ======= * api-change:``events``: Update events client to latest version * api-change:``apigateway``: Update apigateway client to latest version ``` ### 1.12.25 ``` ======= * api-change:``glue``: Update glue client to latest version * api-change:``lightsail``: Update lightsail client to latest version * api-change:``resource-groups``: Update resource-groups client to latest version ``` ### 1.12.24 ``` ======= * api-change:``rds``: Update rds client to latest version * api-change:``lambda``: Update lambda client to latest version * api-change:``servicecatalog``: Update servicecatalog client to latest version ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/botocore - Changelog: https://pyup.io/changelogs/botocore/ - Repo: https://github.com/boto/botocore </details> ### Update [pluggy](https://pypi.org/project/pluggy) from **0.7.1** to **0.8.0**. <details> <summary>Changelog</summary> ### 0.8.0 ``` ========================= Features -------- - `177 <https://github.com/pytest-dev/pluggy/issues/177>`_: Add ``get_hookimpls()`` method to hook callers. Trivial/Internal Changes ------------------------ - `165 <https://github.com/pytest-dev/pluggy/issues/165>`_: Add changelog in long package description and documentation. - `172 <https://github.com/pytest-dev/pluggy/issues/172>`_: Add a test exemplifying the opt-in nature of spec defined args. - `57 <https://github.com/pytest-dev/pluggy/issues/57>`_: Encapsulate hook specifications in a type for easier introspection. ========= Changelog ========= .. towncrier release notes start ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pluggy - Changelog: https://pyup.io/changelogs/pluggy/ - Repo: https://github.com/pytest-dev/pluggy </details> ### Update [urllib3](https://pypi.org/project/urllib3) from **1.23** to **1.24**. <details> <summary>Changelog</summary> ### 1.24 ``` ----------------- * Allow key_server_hostname to be specified when initializing a PoolManager to allow custom SNI to be overridden. (Pull 1449) * Test against Python 3.7 on AppVeyor. (Pull 1453) * Early-out ipv6 checks when running on App Engine. (Pull 1450) * Change ambiguous description of backoff_factor (Pull 1436) * Add ability to handle multiple Content-Encodings (Issue 1441 and Pull 1442) * Skip DNS names that can't be idna-decoded when using pyOpenSSL (Issue 1405). * Add a server_hostname parameter to HTTPSConnection which allows for overriding the SNI hostname sent in the handshake. (Pull 1397) * Drop support for EOL Python 2.6 (Pull 1429 and Pull 1430) * Fixed bug where responses with header Content-Type: message/* erroneously raised HeaderParsingError, resulting in a warning being logged. (Pull 1439) * Move urllib3 to src/urllib3 (Pull 1409) ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/urllib3 - Changelog: https://pyup.io/changelogs/urllib3/ - Docs: https://urllib3.readthedocs.io/ </details> ### Update [google-api-core](https://pypi.org/project/google-api-core) from **1.4.1** to **1.5.0**. *The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/google-api-core - Repo: https://github.com/GoogleCloudPlatform/google-cloud-python </details> ### Update [boto3](https://pypi.org/project/boto3) from **1.9.23** to **1.9.28**. <details> <summary>Changelog</summary> ### 1.9.28 ``` ====== * api-change:``workspaces``: [``botocore``] Update workspaces client to latest version * api-change:``ssm``: [``botocore``] Update ssm client to latest version ``` ### 1.9.27 ``` ====== * api-change:``medialive``: [``botocore``] Update medialive client to latest version * api-change:``route53``: [``botocore``] Update route53 client to latest version * api-change:``appstream``: [``botocore``] Update appstream client to latest version ``` ### 1.9.26 ``` ====== * api-change:``events``: [``botocore``] Update events client to latest version * api-change:``apigateway``: [``botocore``] Update apigateway client to latest version ``` ### 1.9.25 ``` ====== * api-change:``glue``: [``botocore``] Update glue client to latest version * api-change:``lightsail``: [``botocore``] Update lightsail client to latest version * api-change:``resource-groups``: [``botocore``] Update resource-groups client to latest version ``` ### 1.9.24 ``` ====== * api-change:``rds``: [``botocore``] Update rds client to latest version * api-change:``lambda``: [``botocore``] Update lambda client to latest version * api-change:``servicecatalog``: [``botocore``] Update servicecatalog client to latest version ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/boto3 - Changelog: https://pyup.io/changelogs/boto3/ - Repo: https://github.com/boto/boto3 </details> ### Update [djangorestframework](https://pypi.org/project/djangorestframework) from **3.8.2** to **3.9.0**. *The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/djangorestframework - Changelog: https://pyup.io/changelogs/djangorestframework/ - Homepage: https://www.django-rest-framework.org/ </details> ### Update [pytest](https://pypi.org/project/pytest) from **3.8.2** to **3.9.1**. *The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Homepage: https://docs.pytest.org/en/latest/ </details> ### Update [requests](https://pypi.org/project/requests) from **2.19.1** to **2.20.0**. <details> <summary>Changelog</summary> ### 2.20.0 ``` ------------------- **Bugfixes** - Content-Type header parsing is now case-insensitive (e.g. charset=utf8 v Charset=utf8). - Fixed exception leak where certain redirect urls would raise uncaught urllib3 exceptions. - Requests removes Authorization header from requests redirected from https to http on the same hostname. (CVE-2018-18074) - `should_bypass_proxies` now handles URIs without hostnames (e.g. files). **Dependencies** - Requests now supports urllib3 v1.24. **Deprecations** - Requests has officially stopped support for Python 2.6. ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/requests - Changelog: https://pyup.io/changelogs/requests/ - Homepage: http://python-requests.org </details> Co-authored-by: pyup-bot <github-bot@pyup.io>

1594: Scheduled weekly dependency update for week 42 r=peterbe a=pyup-bot ### Update [botocore](https://pypi.org/project/botocore) from **1.12.23** to **1.12.28**. <details> <summary>Changelog</summary> ### 1.12.28 ``` ======= * api-change:``workspaces``: Update workspaces client to latest version * api-change:``ssm``: Update ssm client to latest version ``` ### 1.12.27 ``` ======= * api-change:``medialive``: Update medialive client to latest version * api-change:``route53``: Update route53 client to latest version * api-change:``appstream``: Update appstream client to latest version ``` ### 1.12.26 ``` ======= * api-change:``events``: Update events client to latest version * api-change:``apigateway``: Update apigateway client to latest version ``` ### 1.12.25 ``` ======= * api-change:``glue``: Update glue client to latest version * api-change:``lightsail``: Update lightsail client to latest version * api-change:``resource-groups``: Update resource-groups client to latest version ``` ### 1.12.24 ``` ======= * api-change:``rds``: Update rds client to latest version * api-change:``lambda``: Update lambda client to latest version * api-change:``servicecatalog``: Update servicecatalog client to latest version ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/botocore - Changelog: https://pyup.io/changelogs/botocore/ - Repo: https://github.com/boto/botocore </details> ### Update [pluggy](https://pypi.org/project/pluggy) from **0.7.1** to **0.8.0**. <details> <summary>Changelog</summary> ### 0.8.0 ``` ========================= Features -------- - `177 <https://github.com/pytest-dev/pluggy/issues/177>`_: Add ``get_hookimpls()`` method to hook callers. Trivial/Internal Changes ------------------------ - `165 <https://github.com/pytest-dev/pluggy/issues/165>`_: Add changelog in long package description and documentation. - `172 <https://github.com/pytest-dev/pluggy/issues/172>`_: Add a test exemplifying the opt-in nature of spec defined args. - `57 <https://github.com/pytest-dev/pluggy/issues/57>`_: Encapsulate hook specifications in a type for easier introspection. ========= Changelog ========= .. towncrier release notes start ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pluggy - Changelog: https://pyup.io/changelogs/pluggy/ - Repo: https://github.com/pytest-dev/pluggy </details> ### Update [urllib3](https://pypi.org/project/urllib3) from **1.23** to **1.24**. <details> <summary>Changelog</summary> ### 1.24 ``` ----------------- * Allow key_server_hostname to be specified when initializing a PoolManager to allow custom SNI to be overridden. (Pull 1449) * Test against Python 3.7 on AppVeyor. (Pull 1453) * Early-out ipv6 checks when running on App Engine. (Pull 1450) * Change ambiguous description of backoff_factor (Pull 1436) * Add ability to handle multiple Content-Encodings (Issue 1441 and Pull 1442) * Skip DNS names that can't be idna-decoded when using pyOpenSSL (Issue 1405). * Add a server_hostname parameter to HTTPSConnection which allows for overriding the SNI hostname sent in the handshake. (Pull 1397) * Drop support for EOL Python 2.6 (Pull 1429 and Pull 1430) * Fixed bug where responses with header Content-Type: message/* erroneously raised HeaderParsingError, resulting in a warning being logged. (Pull 1439) * Move urllib3 to src/urllib3 (Pull 1409) ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/urllib3 - Changelog: https://pyup.io/changelogs/urllib3/ - Docs: https://urllib3.readthedocs.io/ </details> ### Update [google-api-core](https://pypi.org/project/google-api-core) from **1.4.1** to **1.5.0**. *The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/google-api-core - Repo: https://github.com/GoogleCloudPlatform/google-cloud-python </details> ### Update [boto3](https://pypi.org/project/boto3) from **1.9.23** to **1.9.28**. <details> <summary>Changelog</summary> ### 1.9.28 ``` ====== * api-change:``workspaces``: [``botocore``] Update workspaces client to latest version * api-change:``ssm``: [``botocore``] Update ssm client to latest version ``` ### 1.9.27 ``` ====== * api-change:``medialive``: [``botocore``] Update medialive client to latest version * api-change:``route53``: [``botocore``] Update route53 client to latest version * api-change:``appstream``: [``botocore``] Update appstream client to latest version ``` ### 1.9.26 ``` ====== * api-change:``events``: [``botocore``] Update events client to latest version * api-change:``apigateway``: [``botocore``] Update apigateway client to latest version ``` ### 1.9.25 ``` ====== * api-change:``glue``: [``botocore``] Update glue client to latest version * api-change:``lightsail``: [``botocore``] Update lightsail client to latest version * api-change:``resource-groups``: [``botocore``] Update resource-groups client to latest version ``` ### 1.9.24 ``` ====== * api-change:``rds``: [``botocore``] Update rds client to latest version * api-change:``lambda``: [``botocore``] Update lambda client to latest version * api-change:``servicecatalog``: [``botocore``] Update servicecatalog client to latest version ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/boto3 - Changelog: https://pyup.io/changelogs/boto3/ - Repo: https://github.com/boto/boto3 </details> ### Update [djangorestframework](https://pypi.org/project/djangorestframework) from **3.8.2** to **3.9.0**. *The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/djangorestframework - Changelog: https://pyup.io/changelogs/djangorestframework/ - Homepage: https://www.django-rest-framework.org/ </details> ### Update [pytest](https://pypi.org/project/pytest) from **3.8.2** to **3.9.1**. *The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Homepage: https://docs.pytest.org/en/latest/ </details> ### Update [requests](https://pypi.org/project/requests) from **2.19.1** to **2.20.0**. <details> <summary>Changelog</summary> ### 2.20.0 ``` ------------------- **Bugfixes** - Content-Type header parsing is now case-insensitive (e.g. charset=utf8 v Charset=utf8). - Fixed exception leak where certain redirect urls would raise uncaught urllib3 exceptions. - Requests removes Authorization header from requests redirected from https to http on the same hostname. (CVE-2018-18074) - `should_bypass_proxies` now handles URIs without hostnames (e.g. files). **Dependencies** - Requests now supports urllib3 v1.24. **Deprecations** - Requests has officially stopped support for Python 2.6. ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/requests - Changelog: https://pyup.io/changelogs/requests/ - Homepage: http://python-requests.org </details> Co-authored-by: pyup-bot <github-bot@pyup.io> Co-authored-by: Mike Cooper <mythmon@gmail.com>

This PR contains the following updates: | Package | Update | Change | References | |---|---|---|---| | pluggy | minor | `==0.7.1` -> `==0.8.0` | [source](https://renovatebot.com/gh/pytest-dev/pluggy) | --- ### Release Notes <details> <summary>pytest-dev/pluggy</summary> ### [`v0.8.0`](https://renovatebot.com/gh/pytest-dev/pluggy/blob/master/CHANGELOG.rst#pluggy-080-2018-10-15) [Compare Source](https://renovatebot.com/gh/pytest-dev/pluggy/compare/0.7.1...0.8.0) ========================= ## Features - `#177 <https://github.com/pytest-dev/pluggy/issues/177>`\_: Add `get_hookimpls()` method to hook callers. ## Trivial/Internal Changes - `#165 <https://github.com/pytest-dev/pluggy/issues/165>`\_: Add changelog in long package description and documentation. - `#172 <https://github.com/pytest-dev/pluggy/issues/172>`\_: Add a test exemplifying the opt-in nature of spec defined args. - `#57 <https://github.com/pytest-dev/pluggy/issues/57>`\_: Encapsulate hook specifications in a type for easier introspection. </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://renovatebot.com/gh/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#mesosphere/dcos-commons).

goodboy requested review from RonnyPfannschmidt, nicoddemus and hpk42 July 7, 2017 23:16

nicoddemus approved these changes Jul 8, 2017

View reviewed changes

goodboy force-pushed the encapsulate_specs branch from aace356 to 44b386c Compare July 8, 2017 03:57

RonnyPfannschmidt reviewed Jul 8, 2017

View reviewed changes

goodboy force-pushed the encapsulate_specs branch from 44b386c to cc524a6 Compare August 29, 2017 14:00

goodboy mentioned this pull request Nov 13, 2017

Project name based collection triggers regression #99

Closed

goodboy force-pushed the encapsulate_specs branch 2 times, most recently from 3f20aa2 to 3a8dc76 Compare November 13, 2017 21:35

goodboy mentioned this pull request Aug 8, 2018

Howto handle hook changes #170

Open

goodboy force-pushed the encapsulate_specs branch from 3a8dc76 to ea96966 Compare August 8, 2018 17:17

goodboy force-pushed the encapsulate_specs branch 3 times, most recently from 23dc109 to cf6b64a Compare August 10, 2018 16:31

RonnyPfannschmidt reviewed Aug 16, 2018

View reviewed changes

fschulze reviewed Aug 16, 2018

View reviewed changes

goodboy force-pushed the encapsulate_specs branch from cf6b64a to 6dc8a7a Compare August 16, 2018 06:10

goodboy force-pushed the encapsulate_specs branch from 6dc8a7a to f6da658 Compare August 16, 2018 06:15

goodboy force-pushed the encapsulate_specs branch from f6da658 to 894b5e2 Compare August 16, 2018 06:22

goodboy commented Aug 19, 2018

View reviewed changes

Add trivial entry

c967e91

goodboy merged commit 1da70c9 into pytest-dev:master Aug 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Encapsulate spec definitions with a class #57

Encapsulate spec definitions with a class #57

goodboy commented Jul 7, 2017 •

edited

nicoddemus left a comment

goodboy commented Jul 8, 2017

RonnyPfannschmidt left a comment

goodboy commented Jul 10, 2017

RonnyPfannschmidt commented Aug 26, 2017

goodboy commented Aug 29, 2017

goodboy commented Aug 8, 2018

fschulze commented Aug 8, 2018 •

edited

fschulze commented Aug 8, 2018

RonnyPfannschmidt Aug 16, 2018

goodboy Aug 16, 2018

fschulze Aug 16, 2018

goodboy Aug 16, 2018

goodboy commented Aug 16, 2018 •

edited

fschulze commented Aug 16, 2018

goodboy commented Aug 16, 2018

nicoddemus commented Aug 18, 2018

goodboy Aug 19, 2018

goodboy Aug 19, 2018

goodboy commented Aug 19, 2018

nicoddemus commented Aug 28, 2018

Encapsulate spec definitions with a class #57

Encapsulate spec definitions with a class #57

Conversation

goodboy commented Jul 7, 2017 • edited

nicoddemus left a comment

Choose a reason for hiding this comment

goodboy commented Jul 8, 2017

RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

goodboy commented Jul 10, 2017

RonnyPfannschmidt commented Aug 26, 2017

goodboy commented Aug 29, 2017

goodboy commented Aug 8, 2018

fschulze commented Aug 8, 2018 • edited

fschulze commented Aug 8, 2018

RonnyPfannschmidt Aug 16, 2018

Choose a reason for hiding this comment

goodboy Aug 16, 2018

Choose a reason for hiding this comment

fschulze Aug 16, 2018

Choose a reason for hiding this comment

goodboy Aug 16, 2018

Choose a reason for hiding this comment

goodboy commented Aug 16, 2018 • edited

fschulze commented Aug 16, 2018

goodboy commented Aug 16, 2018

nicoddemus commented Aug 18, 2018

goodboy Aug 19, 2018

Choose a reason for hiding this comment

goodboy Aug 19, 2018

Choose a reason for hiding this comment

goodboy commented Aug 19, 2018

nicoddemus commented Aug 28, 2018

goodboy commented Jul 7, 2017 •

edited

fschulze commented Aug 8, 2018 •

edited

goodboy commented Aug 16, 2018 •

edited