hooks: fix plugins registering other plugins in a hook #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the other plugins implement the same hook itself. Fix pytest-dev#438. Regressed in 63b7e90 - pluggy 1.1.0. Went with the simple solution described in the issue for now, basically undoing most of the rationale for 63b7e90 (though I think it's still better to have a single `_hookimpls` list).
nicoddemus
approved these changes
Jan 20, 2024
RonnyPfannschmidt
approved these changes
Jan 20, 2024
I will update the changelogs before doing a release. I will do a release in the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the other plugins implement the same hook itself.
Fix #438.
Regressed in 63b7e90 - pluggy 1.1.0.
Went with the simple solution described in the issue for now, basically undoing most of the rationale for 63b7e90 (though I think it's still better to have a single
_hookimplslist).