Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when old-style hookwrapper raises during teardown #464

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Warn when old-style hookwrapper raises during teardown #464

merged 2 commits into from
Jan 21, 2024

Conversation

bluetech
Copy link
Member

Fix #463.

@bluetech
Move _raise_wrapfail to callers.py
d3877d4 
It's only used there.
@bluetech
Copy link
Member Author

Before this can be merged, I want to check how this affects some pluggy users. If this issue is widespread we might want to handle it differently.

@bluetech
Copy link
Member Author

Did downstream testing, seems fine. Though the problems are more likely to occur in 3rd-party plugins of these downstreams, which I didn't check.

I also verified that the warning is issued on the pytest-mpl test suite.

nicoddemus
nicoddemus approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bluetech bluetech merged commit 3a28b4d into pytest-dev:main Jan 21, 2024
14 of 17 checks passed
@bluetech bluetech deleted the hookwrapper-teardown-warning branch January 21, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn when old-style hookwrapper raises during teardown
2 participants
@bluetech @nicoddemus