Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to MyST-Parser from recommonmark #16

Merged
merged 4 commits into from Jun 29, 2021
Merged

Switch to MyST-Parser from recommonmark #16

merged 4 commits into from Jun 29, 2021

Conversation

DrShushen
Copy link
Contributor

Description

As described in this issue on recommonmark GitHub, it is being sunset in favour of MyST-Parser. This PR updates pyscaffoldext-markdown to use MyST-Parser instead.

Closes #14

Details

  • Update to use MyST-parser instead of recommonmark
    • Update dependencies
    • Update templates
    • Modify extension.py accordingly
    • Remove symlink-related code
    • Use new license.template to show license as plain text (rather than trying to parse it as Markdown)
  • Update pyscaffoldext-markdown own docs accordingly

@DrShushen
Update to use MyST-parser instead of Recommonmark
d5a5a5b 
- Update dependencies
- Update templates
- Modify extension.py accordingly
- Remove symlink-related code
- Use new license.template to show license as
raw text
@DrShushen
Update own docs accordingly
0e28476
@DrShushen
Update AUTHORS.md
1846b3b
@DrShushen DrShushen marked this pull request as ready for review June 20, 2021 19:42
@DrShushen
Copy link
Contributor Author

coverage (Linux) appears to be failing with coveralls.exception.CoverallsException: Not on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.

@DrShushen DrShushen mentioned this pull request Jun 21, 2021
Closed
@DrShushen
Copy link
Contributor Author

coverage (Linux) appears to be failing with coveralls.exception.CoverallsException: Not on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.

Seems to be this issue: pyscaffold/pyscaffold#449

@DrShushen
Copy link
Contributor Author

Fetched upstream: 7c45f0c

@FlorianWilhelm
Copy link
Member

@DrShushen, thanks a lot! From my point of view, this looks really, really good!

What does @abravalheri think? He is the expert in everything Markdown ;-)

@abravalheri
Copy link
Contributor

Sorry for the delay guys. It looks good to me, let me just test it locally.

@abravalheri abravalheri merged commit 45cb982 into pyscaffold:master Jun 29, 2021
@abravalheri
Copy link
Contributor

abravalheri commented Jun 29, 2021 •
edited

Thank you very much @DrShushen! ❤️ 🚀 👍

@DrShushen
Copy link
Contributor Author

No problem, glad I could contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abravalheri abravalheri Awaiting requested review from abravalheri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to MyST-Parser from recommonmark (no longer maintained)
3 participants
@DrShushen @FlorianWilhelm @abravalheri